Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tox requires via the config object #1919

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Feb 15, 2021

Fixes #1918

This also fixes broken __str__ of MissingRequirement, which is never actually used but is helpful when debugging.

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation -- I don't know how to properly document the attributes of config. the existing are mostly missing. any ideas? could this be left as another issue?
  • added relevant issue keyword in message body
  • added news fragment in changelog folder
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Fixes tox-dev#1918

This also fixes broken __str__ of MissingRequirement,
which is never actually used but is helpful when debugging.
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 9db3ecf into tox-dev:master Feb 16, 2021
@gaborbernat
Copy link
Member

Release going out via #1920

@hroncok hroncok deleted the config_requires branch February 16, 2021 09:49
ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
Fixes tox-dev#1918

This also fixes broken __str__ of MissingRequirement,
which is never actually used but is helpful when debugging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox requires not exposed in the config object
2 participants