Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API calls that return pathlib.Path instead of str objects #27

Merged
merged 14 commits into from
Jul 23, 2021

Conversation

papr
Copy link
Contributor

@papr papr commented Jul 23, 2021

Implements #3 by wrapping the existing API in pathlib.Path calls and handles multipath-affected API as suggested in #24.

CHANGES.rst Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
src/platformdirs/__init__.py Outdated Show resolved Hide resolved
src/platformdirs/__init__.py Outdated Show resolved Hide resolved
src/platformdirs/__init__.py Outdated Show resolved Hide resolved
src/platformdirs/__init__.py Show resolved Hide resolved
src/platformdirs/api.py Outdated Show resolved Hide resolved
src/platformdirs/api.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #27 (f90a11a) into main (6fe8168) will increase coverage by 1.07%.
The diff coverage is 97.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   89.64%   90.72%   +1.07%     
==========================================
  Files          12       12              
  Lines         425      496      +71     
  Branches       43       44       +1     
==========================================
+ Hits          381      450      +69     
- Misses         31       32       +1     
- Partials       13       14       +1     
Flag Coverage Δ
tests 90.32% <97.18%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/platformdirs/unix.py 74.60% <81.81%> (+1.52%) ⬆️
src/platformdirs/__init__.py 100.00% <100.00%> (ø)
src/platformdirs/api.py 100.00% <100.00%> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe8168...f90a11a. Read the comment docs.

CHANGES.rst Outdated Show resolved Hide resolved
src/platformdirs/unix.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
@gaborbernat gaborbernat marked this pull request as draft July 23, 2021 12:50
@papr papr requested a review from gaborbernat July 23, 2021 13:22
tests/test_api.py Show resolved Hide resolved
@gaborbernat gaborbernat marked this pull request as ready for review July 23, 2021 17:46
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit df07a00 into tox-dev:main Jul 23, 2021
@WhyNotHugo
Copy link
Contributor

Neat, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants