run docker container as non root user #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit runs the docker container with the "build" user (id 1000) which is created in the Dockerfile.
Running as user 1000 has the benefits that:
The potential disadvantage is for distros or customised hosts where the current user is not ID 1000. There are various workarounds in this case, or perhaps it might just be made optional and documented? (I suspect that the majority case is that people are either running a Debian derivative where the default user is likely to be 1000 or running Windows or Mac and often using a VM to allow pass-through of serial ports, in which case again often using a Debian derivative for the VM.)
Let me know what you think and I could add that...