Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 - Fix sundry warnings, update some dependencies #16

Merged
merged 11 commits into from
Aug 1, 2024
Merged

Conversation

totten
Copy link
Owner

@totten totten commented Aug 1, 2024

This is prep for PHP 8.4. It includes a few direct patches for new warnings, and it also updates a bunch of dependencies. A few notable effects:

  • Raise the PHP minimum from 7.1 to 7.3.
  • Drop some patches/overrides for marcj/topsort (which are no longer needed)

@totten totten changed the title composer.json - Require php72. Start using Symfony 5. PHP 8.4 - Fix sundry warnings, update some dependencies Aug 1, 2024
@totten totten force-pushed the master-sym5 branch 3 times, most recently from 7610e79 to 1d502ad Compare August 1, 2024 04:29
@totten
Copy link
Owner Author

totten commented Aug 1, 2024

  • I took a stab at updating the CI rules to also run tests on php84. However, I had trouble -- I suspect it's because php84 is still in alpha, and the relevant Github Actions haven't been updated in a bit. Maybe we try again in the future.
  • However, I have done some local QA on php84:
    • Run phpunit locally ==> OK
    • Run some loco actions (start/stop/clean/etc) in the context of civicrm-buildkit ==> OK

@totten totten merged commit 6e87d2e into master Aug 1, 2024
3 checks passed
@totten totten deleted the master-sym5 branch August 1, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant