Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cLvgl: add template to run lvgl widget demo #270

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

EDGEMTech-GabrielC
Copy link

Provides a template to run LVGL widget demo.

@EDGEMTech-GabrielC
Copy link
Author

Please I have a question. Right now, the template is almost ready. The only last problem I have is that I must embed in a way LVGL repository. I don't think it is a good idea to embed it in the repository and I'd like to know the best way to get this library available to build the application. Any idea ?

@andreriesco
Copy link
Collaborator

Hello @EDGEMTech-GabrielC, one way you could do this is by adding a script that downloads/prepares this repo in the workspace, and than add it's path on the installDepsScrips of the .conf/deps.json file, similar to what is done here in the Mono template

- Update templates.json so that LVGL appears as a choice
- Update tasks.json to fetch LVGL from github if needed
- Simplify + cleanup CMakeLists.txt - hardcode to /dev/fb0
- Provide default configuration lv_conf.h
- Update launch.json so that executable is debugged on the device
cLvgl/docker-compose.yml Outdated Show resolved Hide resolved
cLvgl/Dockerfile.sdk Outdated Show resolved Hide resolved
cLvgl/Dockerfile Outdated Show resolved Hide resolved
cLvgl/Dockerfile.debug Outdated Show resolved Hide resolved
cLvgl/.conf/id_rsa Outdated Show resolved Hide resolved
cLvgl/.conf/id_rsa.pub Outdated Show resolved Hide resolved
@microhobby
Copy link
Collaborator

Hey @EDGEMTech-GabrielC thanks for the contribution, please take a look on the comments and suggestions. Let's us know if you have any doubt or other suggestions.

@microhobby microhobby added the new-template Adding a new template label Nov 13, 2024
cLvgl/.vscode/tasks.json Show resolved Hide resolved
cLvgl/.vscode/c_cpp_properties.json Show resolved Hide resolved
cLvgl/.vscode/launch.json Outdated Show resolved Hide resolved
@microhobby
Copy link
Collaborator

microhobby commented Nov 13, 2024

Hey @EDGEMTech-GabrielC I addressed some of the comments above on https://github.com/microhobby/vscode-torizon-templates/tree/add-cLvgl-template , so take a look if these make sense for you, if yes please add the commits on your branch, or give me the access to push it to your repo. Thanks!

@EDGEMTech-GabrielC
Copy link
Author

I pushed the changes you mentioned, I also gave you access to the repository if you want to change something else.

@andreriesco
Copy link
Collaborator

andreriesco commented Nov 28, 2024

Hello @EDGEMTech-GabrielC ,
I tried to run the Local AMD64, which runs the project for local debugging on my host PC, but got the following error:

Error: cannot open framebuffer device: Permission denied

As the template uses framebuffer, should it be able to have local debugging?

@EDGEMTech-GabrielC
Copy link
Author

Hello @andreriesco,
As the objective is to provide a plugin to help starting with the boards (many great tutorials are made to run LVGL locally), we decided to remove the Local AMD64. A local debugging should not be available.

@microhobby
Copy link
Collaborator

@andreriesco this LGTM

@microhobby microhobby dismissed their stale review December 10, 2024 21:09

Already applied

@andreriesco
Copy link
Collaborator

Actually needs some small fixes and bumps of tags. I will add the commits with the fixes

@microhobby
Copy link
Collaborator

microhobby commented Dec 10, 2024

Actually needs some small fixes and bumps of tags. I will add the commits with the fixes

Could we accept this and then you open a new MR with these small fixes?

@andreriesco
Copy link
Collaborator

I think it's better to wait for the Torizon 7 to be merged into dev before merging this one, to make it available on Torizon 7

@microhobby
Copy link
Collaborator

I think it's better to wait for the Torizon 7 to be merged into dev before merging this one, to make it available on Torizon 7

Ok then.

@kisvegabor
Copy link

Can you tell what is the planned release date of Torizon 7?

@andreriesco
Copy link
Collaborator

Hello @kisvegabor,
Torizon 7 is already available for the OS part. About the IDE templates for Torizon 7, the PR is currently in development, but the release will be at most next month.

@kisvegabor
Copy link

Got it, thank you!

@andreriesco
Copy link
Collaborator

Hello @EDGEMTech-GabrielC @kisvegabor ,
I have tested it on Torizon OS 7 with the bumped tags and it's working both for arm32 and arm64.
However, I am having one last issue. I need to something printed on the Debug Console for the automated tests. I tried adding this line printf("Hello Torizon");, but it's not printing it to the Debug Console. Do you guys have an idea on what might be the issue?

@kisvegabor
Copy link

Great news!

I tried adding this line printf("Hello Torizon");, but it's not printing it to the Debug Console. Do you guys have an idea on what might be the issue?

@EDGEMTech-GabrielC can comment on it in January.

@kisvegabor
Copy link

Gabriel just told me that maybe just a \n is missing: printf("Hello Torizon\n"); and/or please try adding fflush(stdout);

@andreriesco
Copy link
Collaborator

Nice, now it worked, thanks!

Gabriel just told me that maybe just a \n is missing: printf("Hello Torizon\n"); and/or please try adding fflush(stdout);

@microhobby microhobby force-pushed the dev branch 12 times, most recently from 1daf33c to f602a3b Compare January 15, 2025 03:46
Signed-off-by: Gabriel Catel Torres <[email protected]>
@EDGEMTech-GabrielC
Copy link
Author

@andreriesco I replaced the LVGL asset. The previous one had a poor quality. Now that the template is completed, is there anything missing from our side to merge it on the main branch ?

@microhobby microhobby force-pushed the dev branch 6 times, most recently from 22d0146 to 9c5f4d7 Compare January 15, 2025 18:57
@andreriesco
Copy link
Collaborator

Nice, thanks @EDGEMTech-GabrielC,
On your side everything is ok. On our side, I have some commits with small fixes and bumps to Torizon 7 on locally on my computer, and then when the Torizon 7 MR is merged into dev I will rebase it and push this commits

@microhobby microhobby force-pushed the dev branch 3 times, most recently from 97f62c0 to e169b0e Compare January 16, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-template Adding a new template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants