-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cLvgl: add template to run lvgl widget demo #270
base: dev
Are you sure you want to change the base?
Conversation
Please I have a question. Right now, the template is almost ready. The only last problem I have is that I must embed in a way LVGL repository. I don't think it is a good idea to embed it in the repository and I'd like to know the best way to get this library available to build the application. Any idea ? |
Hello @EDGEMTech-GabrielC, one way you could do this is by adding a script that downloads/prepares this repo in the workspace, and than add it's path on the |
- Update templates.json so that LVGL appears as a choice - Update tasks.json to fetch LVGL from github if needed - Simplify + cleanup CMakeLists.txt - hardcode to /dev/fb0 - Provide default configuration lv_conf.h - Update launch.json so that executable is debugged on the device
Hey @EDGEMTech-GabrielC thanks for the contribution, please take a look on the comments and suggestions. Let's us know if you have any doubt or other suggestions. |
Hey @EDGEMTech-GabrielC I addressed some of the comments above on https://github.com/microhobby/vscode-torizon-templates/tree/add-cLvgl-template , so take a look if these make sense for you, if yes please add the commits on your branch, or give me the access to push it to your repo. Thanks! |
Signed-off-by: Gabriel Catel Torres <[email protected]>
Signed-off-by: Gabriel Catel Torres <[email protected]>
Signed-off-by: Gabriel Catel Torres <[email protected]>
I pushed the changes you mentioned, I also gave you access to the repository if you want to change something else. |
Hello @EDGEMTech-GabrielC ,
As the template uses framebuffer, should it be able to have local debugging? |
Hello @andreriesco, |
@andreriesco this LGTM |
Actually needs some small fixes and bumps of tags. I will add the commits with the fixes |
Could we accept this and then you open a new MR with these small fixes? |
I think it's better to wait for the Torizon 7 to be merged into |
Ok then. |
Can you tell what is the planned release date of Torizon 7? |
Hello @kisvegabor, |
Got it, thank you! |
Hello @EDGEMTech-GabrielC @kisvegabor , |
Great news!
@EDGEMTech-GabrielC can comment on it in January. |
Gabriel just told me that maybe just a |
Nice, now it worked, thanks!
|
1daf33c
to
f602a3b
Compare
Signed-off-by: Gabriel Catel Torres <[email protected]>
@andreriesco I replaced the LVGL asset. The previous one had a poor quality. Now that the template is completed, is there anything missing from our side to merge it on the main branch ? |
22d0146
to
9c5f4d7
Compare
Nice, thanks @EDGEMTech-GabrielC, |
97f62c0
to
e169b0e
Compare
Provides a template to run LVGL widget demo.