Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Django < 4.2, Python < 3.10 and fix old mock paths #51

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

tm-kn
Copy link
Member

@tm-kn tm-kn commented Sep 17, 2024

A little tidy up after #50.

  • A few tox.ini updates so the test dependencies are installed more consistently. There were some issues with the setup installing the wrong versions of dependencies.
  • Added a broken mock for the urlopen path for the Wagtail's urlopen import.
  • Deprecate Django less than 4.2 in the setup.cfg.
  • Deprecate Python 3.8 and 3.9 due to issues with boto3 resolving dependencies.

@tm-kn tm-kn marked this pull request as ready for review September 17, 2024 11:42
@tm-kn tm-kn requested a review from zerolab September 17, 2024 11:46
Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

I added a note and a non-blocking suggestion

tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@zerolab
Copy link
Member

zerolab commented Sep 17, 2024

There's something funny with py 3.8/3.9. It errors with django.core.exceptions.ImproperlyConfigured: Could not load Boto3's S3 bindings. No module named 's3transfer.constants'

it loads boto==2.49.0,boto3==1.7.84,botocore==1.10.84,s3transfer==0.1.13

boto3 is at 1.35.x
s3transfer at 0.10.x

upd: on 3.10 it loads "boto3==1.35.20,botocore==1.35.20,s3transfer==0.10.2"

I suggest dropping Python 3.8 as support for it ends in a month - https://endoflife.date/python, and bump min s3transfer and or boto3 versions in testing

@tm-kn
Copy link
Member Author

tm-kn commented Sep 17, 2024

@zerolab Yeah, have been wrangling with this... It seems the easiest way is to drop 3.8 and 3.9. Looks like boto3 moves fast... No one would want to be on modern Django, Wagtail, and old Python. I'd rather not release a broken package to the world.

Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small detail and this is good to go!

Nice one on requiring a minimum of Python 3.10 💪🏼

setup.cfg Show resolved Hide resolved
@tm-kn
Copy link
Member Author

tm-kn commented Sep 17, 2024

it seems that it's urllib3 dependency breaking 3.8 and 3.9.

@tm-kn tm-kn changed the title Deprecate Django < 4.2 and fix old mock paths Deprecate Django < 4.2, Python < 3.10 and fix old mock paths Sep 17, 2024
@tm-kn tm-kn merged commit 30b588b into torchbox:main Sep 17, 2024
7 checks passed
@tm-kn tm-kn deleted the django-lt-42-deprecation branch September 17, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants