New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torch-activate: Never add the current directory to LD_LIBRARY_PATH #228

Open

andersk wants to merge 1 commit into torch:master from andersk:path-separator

Commits on Jun 9, 2017

torch-activate: Never add the current directory to LD_LIBRARY_PATH

The dynamic loader parses a : at the end of LD_LIBRARY_PATH as a
separator delimiting the empty string on its right, which is
interpreted as the current directory.  This can cause all kinds of
hard-to-debug breakage and may be a security vulnerability in certain
contexts.  See:

https://joshumax.github.io/general/2017/06/08/how-torch-broke-ls.html

Correct this using the ${parameter:+word} syntax, which works in all
POSIX shells:

http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_02

Signed-off-by: Anders Kaseorg <[email protected]>

andersk committed Jun 9, 2017