This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
stack_top doc #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
reviewed
Nov 9, 2023
evm/src/cpu/docs/memory-handling.md
Outdated
| ## Operation flag merging | ||
| To reduce the total number of columns, many operation flags are merged together (for example DUP and SWAP). If the two instructions have different stack behaviors, this can be a problem: the filter for an individual operation is now of degree 2 (e.g. `lv.op.dup_swap * lv.opcode_bits[4]` for SWAP) and some constraints of `eval_packed_one` are already of degree 3. | ||
|
|
||
| When this happens, stack constraints are defined manually in the operation's dedicated file (e.g. `dup_swap.rs`). Implementation details vary and can be found in the files; in general they make use of the `stack_inv_aux` and `stack_inv_aux_2` columns to lower the degree of the constraints. |
There was a problem hiding this comment.
there's no explanation of what inv_aux_2 holds?
There was a problem hiding this comment.
I decided to remove any mention to inv_aux_2 and, if needed, to explain more in the dedicated files. Do you think we should still mention it here?
LindaGuiga
pushed a commit
that referenced
this pull request
Feb 19, 2024
Fixes & version bumps to work with Erigon fork
LindaGuiga
pushed a commit
that referenced
this pull request
Feb 19, 2024
Robin's suggested changes for #6 Co-authored-by: Robin Salen <[email protected]>
LindaGuiga
pushed a commit
that referenced
this pull request
Feb 19, 2024
LindaGuiga
pushed a commit
that referenced
this pull request
Feb 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.