-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update-modules-unload-reload #977
base: main
Are you sure you want to change the base?
Feature/update-modules-unload-reload #977
Conversation
} | ||
|
||
println!("{}", t!("Unloading modules...")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Topgrade has added support for i18n, so we need to add translations for this "Unloading modules..." and "Reloading modules..." in line 94.
You can use ChatGPT or other LLM to get them translated.
@soredake, is there anyway you can give this a test? |
@SteveLauC I don't think I can do this without ready-to-use binaries. |
@niStee, mind uploading a binary with this patch so that we can have this patch tested? You can do it in your fork, ref: https://github.com/SteveLauC/topgrade/releases Tip: you can disable the GitHub Action in your fork before drafting a new release: https://github.com/SteveLauC/topgrade/settings/actions |
What does this PR do
Standards checklist
CONTRIBUTING.md
For new steps
--dry-run
option works with this step--yes
option works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.