Configure git through .gitattributes rather than in the workflow

topepo · May 7, 2021 · 193c8b6 · 193c8b6
1 parent 4d56e32
commit 193c8b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1,3 @@
+# On GitHub Actions with Windows, git will use CRLF by default when checking out
+# the repo. If this file has CRLF line endings, R's check process will complain.
+configure.ac text eol=lf
diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml
@@ -38,10 +38,6 @@ jobs:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
 
     steps:
-      # This ensures `configure.ac` isn't given CRLF line endings when cloned
-      - name: Configure git
-        run: git config --global core.autocrlf false
-
       - uses: actions/checkout@v2
 
       - uses: r-lib/actions/setup-r@v1