Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reskin home page and challenge listing / challenge details #6981

Merged
merged 20 commits into from
May 21, 2024
Merged

Conversation

jmgasper
Copy link
Collaborator

<ThriveArticlesFeedContainer itemCount={4} theme="dark" />
<BlogFeedContainer itemCount={4} theme="dark" />
<Viewport id="6sjlJHboX3aG3mFS5FnZND" />
{/* deprecated with https://topcoder.atlassian.net/browse/TOP-1390 */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why leave this in?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkartunov ☝️

{/* deprected with https://topcoder.atlassian.net/browse/CORE-346 */}
{/* <GigsFeed itemCount={5} theme="dark" /> */}
<NewsFeed />
{/* deprecated with https://topcoder.atlassian.net/browse/TOP-1390 */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question -- why comment this out instead of just removing it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkartunov ☝️

reviewOpportunities={reviewOpportunities}
setFilterState={(state) => {
setFilter(state);
// if (activeBucket === BUCKETS.SAVED_FILTER) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove all commented-out lines here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in next commit

Copy link

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

@jmgasper jmgasper merged commit 9d7b395 into master May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants