-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reskin home page and challenge listing / challenge details #6981
Conversation
TOP-1390 talent home refresh
<ThriveArticlesFeedContainer itemCount={4} theme="dark" /> | ||
<BlogFeedContainer itemCount={4} theme="dark" /> | ||
<Viewport id="6sjlJHboX3aG3mFS5FnZND" /> | ||
{/* deprecated with https://topcoder.atlassian.net/browse/TOP-1390 */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why leave this in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kkartunov ☝️
{/* deprected with https://topcoder.atlassian.net/browse/CORE-346 */} | ||
{/* <GigsFeed itemCount={5} theme="dark" /> */} | ||
<NewsFeed /> | ||
{/* deprecated with https://topcoder.atlassian.net/browse/TOP-1390 */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question -- why comment this out instead of just removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kkartunov ☝️
reviewOpportunities={reviewOpportunities} | ||
setFilterState={(state) => { | ||
setFilter(state); | ||
// if (activeBucket === BUCKETS.SAVED_FILTER) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not remove all commented-out lines here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in next commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments.
https://topcoder.atlassian.net/browse/TOP-1393
https://topcoder.atlassian.net/browse/TOP-1390