Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter to TCO20 and TCO21 #5056

Closed
luizrrodrigues opened this issue Oct 5, 2020 · 27 comments
Closed

Update filter to TCO20 and TCO21 #5056

luizrrodrigues opened this issue Oct 5, 2020 · 27 comments
Assignees
Labels
listing:re-implementation P1 Urgent (resolve within 24 hours) Prod Env Environment QA Pass in Staging

Comments

@luizrrodrigues
Copy link
Collaborator

When group have events in challengeFilter, call API with events instead groupId.

Please ref. swagger file: https://github.com/topcoder-platform/challenge-api/blob/4a480a0e7c435a6e3d431fdfa03960bf3ce91455/docs/swagger.yaml#L184-L191

example:

"challengeFilter": {
    "events": ["tco21"]
  },
@luizrrodrigues luizrrodrigues added this to the Release by 10/8/2020 milestone Oct 5, 2020
@crazyk07
Copy link

crazyk07 commented Oct 5, 2020

Contest https://www.topcoder.com/challenges/30144546 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator Author

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 6-8 hours and PR to
https://github.com/topcoder-platform/community-app/tree/listing-develop-sync

https://github.com/topcoder-platform/topcoder-react-lib/tree/listing-develop-sync

run npm run test before PR

@crazyk07
Copy link

crazyk07 commented Oct 6, 2020

Contest https://www.topcoder.com/challenges/30144546 has been updated - Narekvar90 has been unassigned.

This is an automated message for crazyk via Topcoder X

@narekcat narekcat self-assigned this Oct 6, 2020
@crazyk07
Copy link

crazyk07 commented Oct 6, 2020

Contest https://www.topcoder.com/challenges/30144546 has been updated - Narekvar90 has been unassigned.

This is an automated message for crazyk via Topcoder X

@narekcat
Copy link
Contributor

narekcat commented Oct 6, 2020

@luizrrodrigues Hi. Can I work on this issue ?

@luizrrodrigues
Copy link
Collaborator Author

@narekcat yes

@crazyk07
Copy link

crazyk07 commented Oct 6, 2020

Contest https://www.topcoder.com/challenges/30144546 has been updated - it has been assigned to Narekvar90.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator Author

@narekcat any progress in this one?

@narekcat
Copy link
Contributor

narekcat commented Oct 6, 2020

@luizrrodrigues I am still working on this issue. I need more time to finish it. Can I continue to work on it ?

@luizrrodrigues
Copy link
Collaborator Author

@narekcat Sure, please keep me updated.

@narekcat
Copy link
Contributor

narekcat commented Oct 6, 2020

@luizrrodrigues Okay, thank you.

@Oanh-and-only-Oanh
Copy link
Collaborator

@narekcat, please PR ASAP. we need this ticket resolved in time for tomorrow's release.

@SathyaJayabal
Copy link
Collaborator

Dont see the TCO20 and TCO21 in the filter dropdown yet.
Screenshot 2020-10-09 at 8 04 19 AM

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , verified in qa
Screenshot 2020-10-09 at 8 36 56 AM
Screenshot 2020-10-09 at 8 37 03 AM

@sandhiyakavi
Copy link
Collaborator

Verified on staging.

image

image

image

@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-10-09 at 1 21 05 PM
Screenshot 2020-10-09 at 1 21 08 PM

@Oanh-and-only-Oanh
Copy link
Collaborator

@SathyaJayabal @luizrrodrigues,

We don't want to show TCO subcommunitiies in private communities such as Topgear, Zurich and CS. Can you confirm that this is the behavior after the fix?

@luizrrodrigues
Copy link
Collaborator Author

@Oanh-and-only-Oanh Tested in Dev env and TCO are visible in private communities.

@SathyaJayabal Can you check in prod please?

@Oanh-and-only-Oanh
Copy link
Collaborator

@luizrrodrigues it's happening in PROD as well. We need to hide TCO in private communities.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
listing:re-implementation P1 Urgent (resolve within 24 hours) Prod Env Environment QA Pass in Staging
Projects
None yet
Development

No branches or pull requests

6 participants