Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcommunity Filter: Unable to select TCO20 and TCO21 #4976

Closed
SathyaJayabal opened this issue Sep 21, 2020 · 17 comments
Closed

Subcommunity Filter: Unable to select TCO20 and TCO21 #4976

SathyaJayabal opened this issue Sep 21, 2020 · 17 comments
Assignees
Labels
listing:re-implementation P0 Critical (resolve within 4 hours)

Comments

@SathyaJayabal
Copy link
Collaborator

Subcommunity Filter: Unable to select TCO20 and TCO21 from the subcommunity dropdown

TCO20.mov.zip

@SathyaJayabal SathyaJayabal added P3 Normal (resolved within 7 days) listing:re-implementation labels Sep 21, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the Release by 10/1/2020 milestone Sep 21, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added P0 Critical (resolve within 4 hours) and removed P3 Normal (resolved within 7 days) labels Sep 21, 2020
@LieutenantRoger
Copy link
Collaborator

This appears to be the TCO20 and TCO21 are not returning the groupIds, when I couldn't find an groupId, I made it to select 'All'

This could be relevant with the groupIds enhancements feature.

@LieutenantRoger
Copy link
Collaborator

Verified that dev environment doesn't have TCO20 and TCO21 groups. Discussing whether we can create them in dev environment directly

@LieutenantRoger
Copy link
Collaborator

I have made necessary change at community-app, so once a domain doesn't have a groupId, I will not show it in the Sub Community dropdown list. tco20 and tco21 happens to be this case.

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Oct 1, 2020

Here's the PR: #5031

  1. Restore the groupIds per discussion in the slack channel
  2. Hide the community without a groupId, instead of showing them in the dropdown list. So you won't be able to see tco20 and tco21 now.

@luizrrodrigues

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Oct 5, 2020

@LieutenantRoger Looks like add unnecessary hidden: true to meta data: develop...listing-develop-sync

blockchain, cognitive, comcast, cs, iot, mobile, tco20, tco21, veterans, wipro, zurich

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Oct 5, 2020

They are expected per discussion with @Oanh-and-only-Oanh in the slack.

Actually we should only show tco21 and add hidden to all the others, but tco21 doesn't have groupId, so I fall back to show only tco19 for demonstration purpose. Once the tco21 has valid groupIds returned, we can switch tco19 back to tco21

@LieutenantRoger
Copy link
Collaborator

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Oct 5, 2020

@LieutenantRoger Instead hidden: true use hideSearch: true

@LieutenantRoger
Copy link
Collaborator

I thought hidden is used to hide a group, where the hideSearch is used ?

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger sorry, ignore. hideSearch will hide just search icon from header.

hidden looks right one, but have an issue when navigate from listing page to dashboard.

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Oct 5, 2020

@LieutenantRoger , by default we should have an all option that should be selected.

  1. go to listings page
  2. click on dashboard, we get a blank page
  3. Go to listings
  4. select tco19 from sub communities filter
  5. go to dashboard, dashboard is displayed properly.

@LieutenantRoger
Copy link
Collaborator

I will take a look at the all option.

Dashboard page I think you meant this ticket, right ? #5049

It's another ticket.

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Oct 5, 2020

@LieutenantRoger , yes dashboard page is #5049 , but looks like that is only happening when we don't select any sub communities on listings page sub-community filter. Otherwise accessing dashboard directly works. Selecting any subcommunity from listings filter dropdown and then accessing dashboard also works. So I think #5049 is related to this ticket.

@LieutenantRoger
Copy link
Collaborator

ok, let me take a look

@LieutenantRoger
Copy link
Collaborator

Here's the PR for the All option fix: #5052

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal New requirement related with this one: #5056

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , lets close this one and track the sub community filter on #5056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
listing:re-implementation P0 Critical (resolve within 4 hours)
Projects
None yet
Development

No branches or pull requests

4 participants