Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for readability: Add _handle_deprecations, _validate_arguments, _validate_data methods. #166

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

tompollard
Copy link
Owner

This pull request moves some of the content from init into the following methods:

  • _handle_deprecations: reports on deprecated arguments
  • _validate_arguments: runs checks on the input arguments
  • _validate_data: runs checks on the input dataframe

In addition, support for the following arguments has been dropped: labels, isnull, pval_test_name, remarks.

@tompollard tompollard merged commit 767a88c into main Jun 4, 2024
2 checks passed
@tompollard tompollard deleted the tp/refactor1 branch June 4, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant