Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add advice to not define dotted keys out-of-order #646

Merged
merged 5 commits into from
Aug 19, 2019
Merged

Add advice to not define dotted keys out-of-order #646

merged 5 commits into from
Aug 19, 2019

Conversation

LongTengDao
Copy link
Contributor

@LongTengDao LongTengDao commented Aug 6, 2019 •
edited by pradyunsg
Loading

Closes #632

TOML 1.0 +1

workingjubilee
workingjubilee approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@workingjubilee workingjubilee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A somewhat Interesting example, but maybe most apt because of that. Let's get this merged.

README.md Outdated Show resolved Hide resolved
@LongTengDao
Copy link
Contributor Author

Updated after thinking. Thanks for asking.

@rwitzel
Copy link

rwitzel commented Aug 17, 2019

👍 Nice.

ChristianSi
ChristianSi reviewed Aug 18, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ChristianSi
Copy link
Contributor

I made some review comments, looks good otherwise 👍

@pradyunsg
Copy link
Member

Thanks for filing this @LongTengDao and for reviewing this @workingjubilee and @ChristianSi! ^>^

@pradyunsg pradyunsg merged commit cc1c637 into toml-lang:master Aug 19, 2019
@ChristianSi ChristianSi mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianSi ChristianSi ChristianSi approved these changes

@workingjubilee workingjubilee workingjubilee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add advice to not define dotted keys out-of-order
5 participants
@LongTengDao @rwitzel @ChristianSi @pradyunsg @workingjubilee