feat: SDK migration single resource scraping

.github/workflows/templates-build-push-image.yml

@@ -1,5 +1,6 @@
+name: Build and Push (Linux)
 on:
-  workflow_call:
+  workflow_dispatch:
     inputs:
       image_name:
         required: true
@@ -15,6 +16,8 @@ jobs:
   linux:
     name: Build & Push (Linux)
     runs-on: ubuntu-latest
+    permissions:
+      packages: write
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
@@ -40,7 +43,7 @@ jobs:
         uses: docker/login-action@v3
         with:
           registry: ghcr.io
-          username: tomkerkhove
+          username: hkfgo
           password: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Build and push preview image
@@ -49,5 +52,5 @@ jobs:
           build-args: VERSION="${{ env.artifact_full_version }}"
           context: ./src/
           file: ./src/${{ inputs.project_name }}/Dockerfile.linux
-          tags: ${{ env.image_commit_uri }},${{ env.image_latest_uri }}
+          tags: ghcr.io/hkfgo/${{ env.image_commit_uri }},ghcr.io/hkfgo/${{ env.image_latest_uri }}
           push: true

src/Promitor.Agents.Scraper/AzureMonitorClientFactory.cs

@@ -1,11 +1,13 @@
-using System.Collections.Generic;
+using System.Collections.Concurrent;
 using Microsoft.Azure.Management.ResourceManager.Fluent;
 using Microsoft.Extensions.Caching.Memory;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
+using Promitor.Core.Extensions;
 using Promitor.Core.Metrics.Interfaces;
 using Promitor.Core.Metrics.Sinks;
+using Promitor.Core.Serialization.Enum;
 using Promitor.Integrations.Azure.Authentication;
 using Promitor.Integrations.AzureMonitor;
 using Promitor.Integrations.AzureMonitor.Configuration;
@@ -14,7 +16,7 @@ namespace Promitor.Agents.Scraper
 {
     public class AzureMonitorClientFactory
     {
-        private readonly Dictionary<string, AzureMonitorClient> _azureMonitorClients = new();
+        private readonly ConcurrentDictionary<string, IAzureMonitorClient> _azureMonitorClients = new();
 
         /// <summary>
         /// Provides an Azure Monitor client
@@ -29,24 +31,37 @@ public class AzureMonitorClientFactory
         /// <param name="azureMonitorIntegrationConfiguration">Options for Azure Monitor integration</param>
         /// <param name="azureMonitorLoggingConfiguration">Options for Azure Monitor logging</param>
         /// <param name="loggerFactory">Factory to create loggers with</param>
-        public AzureMonitorClient CreateIfNotExists(AzureEnvironment cloud, string tenantId, string subscriptionId, MetricSinkWriter metricSinkWriter, IAzureScrapingSystemMetricsPublisher azureScrapingSystemMetricsPublisher, IMemoryCache resourceMetricDefinitionMemoryCache, IConfiguration configuration, IOptions<AzureMonitorIntegrationConfiguration> azureMonitorIntegrationConfiguration, IOptions<AzureMonitorLoggingConfiguration> azureMonitorLoggingConfiguration, ILoggerFactory loggerFactory)
-        {
+        /// <param name="useAzureMonitorSdk">Whether to use the new Azure.Monitor.Query package for queries</param>
+        public IAzureMonitorClient CreateIfNotExists(AzureCloud cloud, string tenantId, string subscriptionId, MetricSinkWriter metricSinkWriter, IAzureScrapingSystemMetricsPublisher azureScrapingSystemMetricsPublisher, IMemoryCache resourceMetricDefinitionMemoryCache, IConfiguration configuration, IOptions<AzureMonitorIntegrationConfiguration> azureMonitorIntegrationConfiguration, IOptions<AzureMonitorLoggingConfiguration> azureMonitorLoggingConfiguration, ILoggerFactory loggerFactory, bool useAzureMonitorSdk)
+        {   
             if (_azureMonitorClients.TryGetValue(subscriptionId, out var value))
             {
                 return value;
             }
 
-            var azureMonitorClient = CreateNewAzureMonitorClient(cloud, tenantId, subscriptionId, metricSinkWriter, azureScrapingSystemMetricsPublisher, resourceMetricDefinitionMemoryCache, configuration, azureMonitorIntegrationConfiguration, azureMonitorLoggingConfiguration, loggerFactory);
+            IAzureMonitorClient azureMonitorClient;
+            if (useAzureMonitorSdk) {
+                azureMonitorClient = CreateNewAzureMonitorQueryClient(cloud, tenantId, subscriptionId, metricSinkWriter, azureScrapingSystemMetricsPublisher, resourceMetricDefinitionMemoryCache, configuration, azureMonitorIntegrationConfiguration, azureMonitorLoggingConfiguration, loggerFactory);
+            } else {
+                azureMonitorClient = CreateNewLegacyAzureMonitorClient(cloud.GetAzureEnvironment(), tenantId, subscriptionId, metricSinkWriter, azureScrapingSystemMetricsPublisher, resourceMetricDefinitionMemoryCache, configuration, azureMonitorIntegrationConfiguration, azureMonitorLoggingConfiguration, loggerFactory);
+            }
             _azureMonitorClients.TryAdd(subscriptionId, azureMonitorClient);
 
             return azureMonitorClient;
         }
 
-        private static AzureMonitorClient CreateNewAzureMonitorClient(AzureEnvironment cloud, string tenantId, string subscriptionId, MetricSinkWriter metricSinkWriter, IAzureScrapingSystemMetricsPublisher azureScrapingSystemMetricsPublisher, IMemoryCache resourceMetricDefinitionMemoryCache, IConfiguration configuration, IOptions<AzureMonitorIntegrationConfiguration> azureMonitorIntegrationConfiguration, IOptions<AzureMonitorLoggingConfiguration> azureMonitorLoggingConfiguration, ILoggerFactory loggerFactory)
+        private static LegacyAzureMonitorClient CreateNewLegacyAzureMonitorClient(AzureEnvironment cloud, string tenantId, string subscriptionId, MetricSinkWriter metricSinkWriter, IAzureScrapingSystemMetricsPublisher azureScrapingSystemMetricsPublisher, IMemoryCache resourceMetricDefinitionMemoryCache, IConfiguration configuration, IOptions<AzureMonitorIntegrationConfiguration> azureMonitorIntegrationConfiguration, IOptions<AzureMonitorLoggingConfiguration> azureMonitorLoggingConfiguration, ILoggerFactory loggerFactory)
         {
             var azureCredentials = AzureAuthenticationFactory.GetConfiguredAzureAuthentication(configuration);
-            var azureMonitorClient = new AzureMonitorClient(cloud, tenantId, subscriptionId, azureCredentials, metricSinkWriter, azureScrapingSystemMetricsPublisher, resourceMetricDefinitionMemoryCache, loggerFactory, azureMonitorIntegrationConfiguration, azureMonitorLoggingConfiguration);
-            return azureMonitorClient;
+            var azureMonitorClientLegacy = new LegacyAzureMonitorClient(cloud, tenantId, subscriptionId, azureCredentials, metricSinkWriter, azureScrapingSystemMetricsPublisher, resourceMetricDefinitionMemoryCache, loggerFactory, azureMonitorIntegrationConfiguration, azureMonitorLoggingConfiguration);
+            return azureMonitorClientLegacy;
+        }
+
+        private static AzureMonitorQueryClient CreateNewAzureMonitorQueryClient(AzureCloud cloud, string tenantId, string subscriptionId, MetricSinkWriter metricSinkWriter, IAzureScrapingSystemMetricsPublisher azureScrapingSystemMetricsPublisher, IMemoryCache resourceMetricDefinitionMemoryCache, IConfiguration configuration, IOptions<AzureMonitorIntegrationConfiguration> azureMonitorIntegrationConfiguration, IOptions<AzureMonitorLoggingConfiguration> azureMonitorLoggingConfiguration, ILoggerFactory loggerFactory)
+        {
+            var azureCredentials = AzureAuthenticationFactory.GetConfiguredAzureAuthentication(configuration);
+            var azureMonitorQueryClient = new AzureMonitorQueryClient(cloud, tenantId, subscriptionId, azureCredentials, metricSinkWriter, azureScrapingSystemMetricsPublisher, resourceMetricDefinitionMemoryCache, loggerFactory, azureMonitorIntegrationConfiguration, azureMonitorLoggingConfiguration);
+            return azureMonitorQueryClient;
         }
     }
 }

src/Promitor.Agents.Scraper/Scheduling/ResourcesScrapingJob.cs

@@ -12,6 +12,7 @@
 using Microsoft.Extensions.Options;
 using Promitor.Agents.Scraper.Discovery.Interfaces;
 using Promitor.Core.Contracts;
+using Promitor.Core.Extensions;
 using Promitor.Core.Metrics.Interfaces;
 using Promitor.Core.Metrics.Sinks;
 using Promitor.Core.Scraping.Configuration.Model;
@@ -275,13 +276,14 @@ private async Task ScrapeMetric(ScrapeDefinition<IAzureResourceDefinition> scrap
                 var resourceSubscriptionId = !string.IsNullOrWhiteSpace(scrapeDefinition.Resource.SubscriptionId)
                     ? scrapeDefinition.Resource.SubscriptionId
                     : _metricsDeclaration.AzureMetadata.SubscriptionId;
+                Logger.LogInformation("Parsed SDK Config {UseAzureMonitorSdk}", _metricsDeclaration.UseAzureMonitorSdk);
                 var azureMonitorClient = _azureMonitorClientFactory.CreateIfNotExists(_metricsDeclaration.AzureMetadata.Cloud, _metricsDeclaration.AzureMetadata.TenantId,
                     resourceSubscriptionId, _metricSinkWriter, _azureScrapingSystemMetricsPublisher, _resourceMetricDefinitionMemoryCache, _configuration,
-                    _azureMonitorIntegrationConfiguration, _azureMonitorLoggingConfiguration, _loggerFactory);
+                    _azureMonitorIntegrationConfiguration, _azureMonitorLoggingConfiguration, _loggerFactory, _metricsDeclaration.UseAzureMonitorSdk);
 
-                var tokenCredential = AzureAuthenticationFactory.GetTokenCredential(_metricsDeclaration.AzureMetadata.Cloud.ManagementEndpoint, _metricsDeclaration.AzureMetadata.TenantId,
-                    AzureAuthenticationFactory.GetConfiguredAzureAuthentication(_configuration), new Uri(_metricsDeclaration.AzureMetadata.Cloud.AuthenticationEndpoint));
-                var logAnalyticsClient = new LogAnalyticsClient(_loggerFactory, _metricsDeclaration.AzureMetadata.Cloud, tokenCredential);
+                var tokenCredential = AzureAuthenticationFactory.GetTokenCredential(_metricsDeclaration.AzureMetadata.Cloud.GetAzureEnvironment().ManagementEndpoint, _metricsDeclaration.AzureMetadata.TenantId,
+                    AzureAuthenticationFactory.GetConfiguredAzureAuthentication(_configuration), new Uri(_metricsDeclaration.AzureMetadata.Cloud.GetAzureEnvironment().AuthenticationEndpoint));
+                var logAnalyticsClient = new LogAnalyticsClient(_loggerFactory, _metricsDeclaration.AzureMetadata.Cloud.GetAzureEnvironment(), tokenCredential);
 
                 var scraper = _metricScraperFactory.CreateScraper(scrapeDefinition.Resource.ResourceType, _metricSinkWriter, _azureScrapingSystemMetricsPublisher, azureMonitorClient, logAnalyticsClient);
                 await scraper.ScrapeAsync(scrapeDefinition);

src/Promitor.Agents.Scraper/Usability/MetricsTableGenerator.cs

@@ -36,7 +36,7 @@ private void PlotAzureMetadataInAsciiTable(AzureMetadata metadata)
         {
             var asciiTable = CreateAzureMetadataAsciiTable();
 
-            asciiTable.AddRow(metadata.TenantId, metadata.SubscriptionId, metadata.ResourceGroupName, metadata.Cloud.Name.Humanize(LetterCasing.Title));
+            asciiTable.AddRow(metadata.TenantId, metadata.SubscriptionId, metadata.ResourceGroupName, metadata.Cloud.Humanize(LetterCasing.Title));
 
             AnsiConsole.Write(asciiTable);
         }

src/Promitor.Core.Scraping/AzureMonitorScraper.cs

@@ -3,7 +3,6 @@
 using System.Linq;
 using System.Threading.Tasks;
 using GuardNet;
-using Microsoft.Azure.Management.Monitor.Fluent.Models;
 using Microsoft.Extensions.Logging;
 using Promitor.Core.Contracts;
 using Promitor.Core.Metrics;
@@ -29,7 +28,7 @@ protected AzureMonitorScraper(ScraperConfiguration scraperConfiguration) :
         }
 
         /// <inheritdoc />
-        protected override async Task<ScrapeResult> ScrapeResourceAsync(string subscriptionId, ScrapeDefinition<IAzureResourceDefinition> scrapeDefinition, TResourceDefinition resourceDefinition, AggregationType aggregationType, TimeSpan aggregationInterval)
+        protected override async Task<ScrapeResult> ScrapeResourceAsync(string subscriptionId, ScrapeDefinition<IAzureResourceDefinition> scrapeDefinition, TResourceDefinition resourceDefinition, PromitorMetricAggregationType aggregationType, TimeSpan aggregationInterval)
         {
             Guard.NotNull(scrapeDefinition, nameof(scrapeDefinition));
             Guard.NotNull(scrapeDefinition.AzureMetricConfiguration, nameof(scrapeDefinition.AzureMetricConfiguration));

src/Promitor.Core.Scraping/Configuration/Model/AzureMetadata.cs

@@ -1,4 +1,4 @@
-using Microsoft.Azure.Management.ResourceManager.Fluent;
+using Promitor.Core.Serialization.Enum;
 
 namespace Promitor.Core.Scraping.Configuration.Model
 {
@@ -7,6 +7,6 @@ public class AzureMetadata
         public string ResourceGroupName { get; set; }
         public string SubscriptionId { get; set; }
         public string TenantId { get; set; }
-        public AzureEnvironment Cloud { get; set; }
+        public AzureCloud Cloud { get; set; }
     }
 }

src/Promitor.Core.Scraping/Configuration/Model/MetricAggregation.cs

@@ -1,4 +1,5 @@
-using Microsoft.Azure.Management.Monitor.Fluent.Models;
+
+using Promitor.Core.Metrics;
 
 namespace Promitor.Core.Scraping.Configuration.Model
 {
@@ -7,6 +8,6 @@ public class MetricAggregation : Aggregation
         /// <summary>
         ///     Type of aggregation to query the Azure Monitor metric
         /// </summary>
-        public AggregationType Type { get; set; }
+        public PromitorMetricAggregationType Type { get; set; }
     }
 }

src/Promitor.Core.Scraping/Configuration/Model/MetricsDeclaration.cs

@@ -5,6 +5,7 @@ namespace Promitor.Core.Scraping.Configuration.Model
 {
     public class MetricsDeclaration
     {
+        public bool UseAzureMonitorSdk { get; set; } = true;
         public AzureMetadata AzureMetadata { get; set; }
         public MetricDefaults MetricDefaults { get; set; } = new MetricDefaults();
         public List<MetricDefinition> Metrics { get; set; } = new List<MetricDefinition>();

src/Promitor.Core.Scraping/Configuration/Serialization/v1/Core/AzureMetadataDeserializer.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using Microsoft.Azure.Management.ResourceManager.Fluent;
 using Microsoft.Extensions.Logging;
 using Promitor.Core.Extensions;
 using Promitor.Core.Scraping.Configuration.Serialization.v1.Model;
@@ -20,18 +19,19 @@ public AzureMetadataDeserializer(ILogger<AzureMetadataDeserializer> logger) : ba
             Map(metadata => metadata.ResourceGroupName)
                 .IsRequired();
             Map(metadata => metadata.Cloud)
-                .WithDefault(AzureEnvironment.AzureGlobalCloud)
+                .WithDefault(AzureCloud.Global)
                 .MapUsing(DetermineAzureCloud);
         }
 
+        // TODO: validate cloud configuration in a SDK-agnostic way
         private object DetermineAzureCloud(string rawAzureCloud, KeyValuePair<YamlNode, YamlNode> nodePair, IErrorReporter errorReporter)
         {
             if (Enum.TryParse<AzureCloud>(rawAzureCloud, out var azureCloud))
             {
                 try
                 {
-                    var azureEnvironment = azureCloud.GetAzureEnvironment();
-                    return azureEnvironment;
+                    azureCloud.DetermineMetricsClientAudience();
+                    return azureCloud;
                 }
                 catch (ArgumentOutOfRangeException)
                 {

src/Promitor.Core.Scraping/Configuration/Serialization/v1/Core/V1Deserializer.cs

@@ -20,6 +20,8 @@ public V1Deserializer(IDeserializer<AzureMetadataV1> azureMetadataDeserializer,
             Map(definition => definition.Version)
                 .IsRequired()
                 .MapUsing(GetVersion);
+            Map(definition => definition.UseAzureMonitorSdk)
+                .WithDefault(true);
             Map(definition => definition.AzureMetadata)
                 .IsRequired()
                 .MapUsingDeserializer(azureMetadataDeserializer);

src/Promitor.Core.Scraping/Configuration/Serialization/v1/Model/AzureMetadataV1.cs

@@ -1,4 +1,4 @@
-using Microsoft.Azure.Management.ResourceManager.Fluent;
+using Promitor.Core.Serialization.Enum;
 
 namespace Promitor.Core.Scraping.Configuration.Serialization.v1.Model
 {
@@ -7,6 +7,6 @@ public class AzureMetadataV1
         public string TenantId { get; set; }
         public string SubscriptionId { get; set; }
         public string ResourceGroupName { get; set; }
-        public AzureEnvironment Cloud { get; set; }
+        public AzureCloud Cloud { get; set; }
     }
 }

src/Promitor.Core.Scraping/Configuration/Serialization/v1/Model/MetricAggregationV1.cs

@@ -1,5 +1,5 @@
 using System;
-using Microsoft.Azure.Management.Monitor.Fluent.Models;
+using Promitor.Core.Metrics;
 
 namespace Promitor.Core.Scraping.Configuration.Serialization.v1.Model
 {
@@ -16,6 +16,6 @@ public class MetricAggregationV1
         /// <summary>
         /// Type of aggregation to query the Azure Monitor metric.
         /// </summary>
-        public AggregationType? Type { get; set; }
+        public PromitorMetricAggregationType? Type { get; set; }
     }
 }

src/Promitor.Core.Scraping/Configuration/Serialization/v1/Model/MetricsDeclarationV1.cs

@@ -9,6 +9,7 @@ namespace Promitor.Core.Scraping.Configuration.Serialization.v1.Model
     public class MetricsDeclarationV1
     {
         public string Version { get; set; } = SpecVersion.v1.ToString();
+        public bool UseAzureMonitorSdk { get; set; } = true;
         public AzureMetadataV1 AzureMetadata { get; set; }
         public MetricDefaultsV1 MetricDefaults { get; set; }
         public IReadOnlyCollection<MetricDefinitionV1> Metrics { get; set; }

src/Promitor.Core.Scraping/Factories/MetricScraperFactory.cs

@@ -31,119 +31,119 @@
         /// <param name="azureScrapingSystemMetricsPublisher">Collector to send metrics related to the runtime</param>
         /// <param name="azureMonitorClient">Client to interact with Azure Monitor</param>
         /// <param name="logAnalyticsClient">Client to interact with Log Analytics</param>
-        public IScraper<IAzureResourceDefinition> CreateScraper(ResourceType metricDefinitionResourceType, MetricSinkWriter metricSinkWriter, IAzureScrapingSystemMetricsPublisher azureScrapingSystemMetricsPublisher, AzureMonitorClient azureMonitorClient, LogAnalyticsClient logAnalyticsClient)
+        public IScraper<IAzureResourceDefinition> CreateScraper(ResourceType metricDefinitionResourceType, MetricSinkWriter metricSinkWriter, IAzureScrapingSystemMetricsPublisher azureScrapingSystemMetricsPublisher, IAzureMonitorClient azureMonitorClient, LogAnalyticsClient logAnalyticsClient)
         {
             var scraperConfiguration = new ScraperConfiguration(azureMonitorClient, logAnalyticsClient, metricSinkWriter, azureScrapingSystemMetricsPublisher, _logger);
 
             switch (metricDefinitionResourceType)
             {
                 case ResourceType.ApiManagement:
                     return new ApiManagementScraper(scraperConfiguration);
                 case ResourceType.ApplicationGateway:
                     return new ApplicationGatewayScraper(scraperConfiguration);
                 case ResourceType.ApplicationInsights:
                     return new ApplicationInsightsScraper(scraperConfiguration);
                 case ResourceType.AppPlan:
                     return new AppPlanScraper(scraperConfiguration);
                 case ResourceType.AutomationAccount:
                     return new AutomationAccountScraper(scraperConfiguration);
                 case ResourceType.BlobStorage:
                     return new BlobStorageScraper(scraperConfiguration);
                 case ResourceType.Cdn:
                     return new CdnScraper(scraperConfiguration);
                 case ResourceType.ContainerInstance:
                     return new ContainerInstanceScraper(scraperConfiguration);
                 case ResourceType.ContainerRegistry:
                     return new ContainerRegistryScraper(scraperConfiguration);
                 case ResourceType.CosmosDb:
                     return new CosmosDbScraper(scraperConfiguration);
                 case ResourceType.DataExplorerCluster:
                     return new DataExplorerClusterScraper(scraperConfiguration);
                 case ResourceType.DataFactory:
                     return new DataFactoryScraper(scraperConfiguration);
                 case ResourceType.DataShare:
                     return new DataShareScraper(scraperConfiguration);
                 case ResourceType.DeviceProvisioningService:
                     return new DeviceProvisioningServiceScraper(scraperConfiguration);
                 case ResourceType.EventHubs:
                     return new EventHubsScraper(scraperConfiguration);
                 case ResourceType.ExpressRouteCircuit:
                     return new ExpressRouteCircuitScraper(scraperConfiguration);
                 case ResourceType.FileStorage:
                     return new FileStorageScraper(scraperConfiguration);
                 case ResourceType.FrontDoor:
                     return new FrontDoorScraper(scraperConfiguration);
                 case ResourceType.FunctionApp:
                     return new FunctionAppScraper(scraperConfiguration);
                 case ResourceType.Generic:
                     return new GenericScraper(scraperConfiguration);
                 case ResourceType.IoTHub:
                     return new IoTHubScraper(scraperConfiguration);
                 case ResourceType.KeyVault:
                     return new KeyVaultScraper(scraperConfiguration);
                 case ResourceType.KubernetesService:
                     return new KubernetesServiceScraper(scraperConfiguration);
                 case ResourceType.LoadBalancer:
                     return new LoadBalancerScraper(scraperConfiguration);
                 case ResourceType.LogAnalytics:
                     return new LogAnalyticsScraper(scraperConfiguration);
                 case ResourceType.LogicApp:
                     return new LogicAppScraper(scraperConfiguration);
                 case ResourceType.MariaDb:
                     return new MariaDbScraper(scraperConfiguration);
                 case ResourceType.MonitorAutoscale:
                     return new MonitorAutoscaleScraper(scraperConfiguration);
                 case ResourceType.MySql:
                     return new MySqlScraper(scraperConfiguration);
                 case ResourceType.NatGateway:
                     return new NatGatewayScraper(scraperConfiguration);
                 case ResourceType.NetworkGateway:
                     return new NetworkGatewayScraper(scraperConfiguration);
                 case ResourceType.NetworkInterface:
                     return new NetworkInterfaceScraper(scraperConfiguration);
                 case ResourceType.PostgreSql:
                     return new PostgreSqlScraper(scraperConfiguration);
                 case ResourceType.PowerBiDedicated:
                     return new PowerBiDedicatedScraper(scraperConfiguration);
                 case ResourceType.PublicIpAddress:
                     return new PublicIpAddressScraper(scraperConfiguration);
                 case ResourceType.RedisCache:
                     return new RedisCacheScraper(scraperConfiguration);
                 case ResourceType.RedisEnterpriseCache:
                     return new RedisEnterpriseCacheScraper(scraperConfiguration);
                 case ResourceType.ServiceBusNamespace:
                     return new ServiceBusNamespaceScraper(scraperConfiguration);
                 case ResourceType.SqlDatabase:
                     return new SqlDatabaseScraper(scraperConfiguration);
                 case ResourceType.SqlElasticPool:
                     return new SqlElasticPoolScraper(scraperConfiguration);
                 case ResourceType.SqlManagedInstance:
                     return new SqlManagedInstanceScraper(scraperConfiguration);
                 case ResourceType.SqlServer:
                     return new SqlServerScraper(scraperConfiguration);
                 case ResourceType.StorageAccount:
                     return new StorageAccountScraper(scraperConfiguration);
                 case ResourceType.StorageQueue:
                     return new StorageQueueScraper(scraperConfiguration);
                 case ResourceType.SynapseApacheSparkPool:
                     return new SynapseApacheSparkPoolScraper(scraperConfiguration);
                 case ResourceType.SynapseSqlPool:
                     return new SynapseSqlPoolScraper(scraperConfiguration);
                 case ResourceType.SynapseWorkspace:
                     return new SynapseWorkspaceScraper(scraperConfiguration);
                 case ResourceType.TrafficManager:
                     return new TrafficManagerScraper(scraperConfiguration);
                 case ResourceType.VirtualMachine:
                     return new VirtualMachineScraper(scraperConfiguration);
                 case ResourceType.VirtualMachineScaleSet:
                     return new VirtualMachineScaleSetScraper(scraperConfiguration);
                 case ResourceType.VirtualNetwork:
                     return new VirtualNetworkScraper(scraperConfiguration);
                 case ResourceType.WebApp:
                     return new WebAppScraper(scraperConfiguration);
                 default:
                     throw new ArgumentOutOfRangeException(nameof(metricDefinitionResourceType), metricDefinitionResourceType, "Matching scraper not found");
             }
         }
     }
 }