fix: Improve AzureMonitorScraper Error Handling for Time Series Missing Requested Dimension Value #1511
tomkerkhoveci-code.yml
on: pull_request
Verify Codebase
2m 41s
Code Quality (R#)
3m 26s
Annotations
1 error, 6 warnings, and 10 notices
|
Code Quality (R#)
Issues found.
|
|
Verify Codebase:
src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L20
The literal or constant value 1 should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'Create_MeasuredMetric_With_Single_Dimension_HappyPath_Succeeds' on type 'MeasuredMetricTest'. Swap the parameter values.
|
|
Verify Codebase:
src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L20
The literal or constant value 1 should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'Create_MeasuredMetric_With_Single_Dimension_HappyPath_Succeeds' on type 'MeasuredMetricTest'. Swap the parameter values.
|
|
Verify Codebase:
src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L20
The literal or constant value 1 should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'Create_MeasuredMetric_With_Single_Dimension_HappyPath_Succeeds' on type 'MeasuredMetricTest'. Swap the parameter values.
|
|
Code Quality (R#):
src/Promitor.Integrations.AzureMonitor/AzureMonitorClient.cs#L25
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/promitor/promitor/src/Promitor.Integrations.AzureMonitor/AzureMonitorClient.cs(25,979)
|
|
Code Quality (R#):
src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L20
"[xUnit2000] The literal or constant value 1 should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'Create_MeasuredMetric_With_Single_Dimension_HappyPath_Succeeds' on type 'MeasuredMetricTest'. Swap the parameter values." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs(20,804)
|
|
Code Quality (R#):
src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L30
"[RedundantEmptyObjectOrCollectionInitializer] Empty object or collection initializer list is redundant" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs(30,1343)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(12,317)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L23
"[MemberCanBeProtected.Global] Method 'CreatePromitorWebHost' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(23,880)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L28
"[SuggestVarOrType_SimpleTypes] Use 'var' (simple types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(28,1260)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L54
"[MemberCanBePrivate.Global] Method 'DetermineHttpPort' can be made private" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(54,2323)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L66
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(66,2766)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L79
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(79,3190)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(12,306)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L18
"[MemberCanBeProtected.Global] Property 'Configuration' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(18,446)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L53
"[VirtualMemberNeverOverridden.Global] Virtual method 'CreateSerilogConfiguration' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(53,1991)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L75
"[VirtualMemberNeverOverridden.Global] Virtual method 'EnrichTelemetry' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(75,3329)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
test-results
Expired
|
2.1 MB |
|