feat: Enabling DefaultAzureCredential for AuthenticationMode #3001
Annotations
1 error, 11 warnings, and 10 notices
|
R# Code Quality
Issues found.
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs#L22
"[InconsistentNaming] Name 'AzureMetricConfigurationBase' does not match rule 'Static readonly fields (private)'. Suggested name is 'azureMetricConfigurationBase'." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs(22,60)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L24
"[InconsistentNaming] Name 'AzureMetricConfigurationBase' does not match rule 'Static readonly fields (private)'. Suggested name is 'azureMetricConfigurationBase'." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(24,60)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs#L18
"[InconsistentNaming] Name 'AzureMetricNameBase' does not match rule 'Static readonly fields (private)'. Suggested name is 'azureMetricNameBase'." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs(18,40)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L20
"[InconsistentNaming] Name 'AzureMetricNameBase' does not match rule 'Static readonly fields (private)'. Suggested name is 'azureMetricNameBase'." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(20,40)
|
|
R# Code Quality:
src/Promitor.Integrations.Sinks.OpenTelemetry/OpenTelemetryCollectorMetricSink.cs#L20
"[InconsistentNaming] Name 'AzureMonitorMeter' does not match rule 'Static readonly fields (private)'. Suggested name is 'azureMonitorMeter'." on /home/runner/work/promitor/promitor/src/Promitor.Integrations.Sinks.OpenTelemetry/OpenTelemetryCollectorMetricSink.cs(20,39)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L45
"[InconsistentNaming] Name 'BatchSize' does not match rule 'Static readonly fields (private)'. Suggested name is 'batchSize'." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(45,37)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Generators/ScrapeResultGenerator.cs#L10
"[InconsistentNaming] Name 'Bogus' does not match rule 'Static readonly fields (private)'. Suggested name is 'bogus'." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Generators/ScrapeResultGenerator.cs(10,39)
|
|
R# Code Quality:
src/Promitor.Core.Scraping/Configuration/Serialization/v1/Core/AggregationDeserializer.cs#L9
"[InconsistentNaming] Name 'DefaultAggregationInterval' does not match rule 'Static readonly fields (private)'. Suggested name is 'defaultAggregationInterval'." on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Serialization/v1/Core/AggregationDeserializer.cs(9,42)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Serialization/DeserializerTests/DeserializationTests.cs#L13
"[InconsistentNaming] Name 'DefaultInterval' does not match rule 'Static readonly fields (private)'. Suggested name is 'defaultInterval'." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Serialization/DeserializerTests/DeserializationTests.cs(13,42)
|
|
R# Code Quality:
src/Promitor.Agents.Scraper/Discovery/StubResourceDiscoveryRepository.cs#L11
"[InconsistentNaming] Name 'EmptyResourceDefinitions' does not match rule 'Static readonly fields (private)'. Suggested name is 'emptyResourceDefinitions'." on /home/runner/work/promitor/promitor/src/Promitor.Agents.Scraper/Discovery/StubResourceDiscoveryRepository.cs(11,63)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs#L18
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs(18,9)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs#L19
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs(19,9)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs#L21
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs(21,9)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs#L22
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs(22,9)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs#L30
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs(30,9)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs#L38
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs(38,9)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L20
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(20,9)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L21
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(21,9)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L23
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(23,9)
|
|
R# Code Quality:
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L24
"[ArrangeModifiersOrder] Inconsistent modifiers declaration order" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(24,9)
|
Loading