Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NodeJS to latest LTS (12.16.2) #483

Closed
wants to merge 1 commit into from
Closed

Conversation

makew0rld
Copy link
Contributor

@makew0rld makew0rld commented Apr 11, 2020

This is a small PR, but the biggest change is that armv6 is left behind. NodeJS no longer supports it, and so I've set it up to download the 10.x LTS instead. Should we be compiling our own versions of NodeJS for armv6 and 32-bit arches, which are stuck on the 8.x LTS? I opened #484 to talk about that. For now I think this can be merged.

@makew0rld
Copy link
Contributor Author

This needs to be confirmed to work - that it can successfully install ssb, before merging. I have tried and it failed. I believe this is because ssb-server relies on the sodium-native pkg, at v2.4.2. I have not confirmed this myself, but it's what @darkdrgn2k said. As can be seen in this issue, only in v2.4.3 and above did sodium-native support building with Node v12. As such, using this newer Node version causes the command npm install ssb-server to fail.

@makew0rld
Copy link
Contributor Author

On the ssb-server README they say to install Node v10 explicitly. We could use a solution like nvm to manage multiple Node versions, but unless some other part of the code needs a higher version than maybe this PR can stay unmerged.

@darkdrgn2k
Copy link
Contributor

Moved to 14

@darkdrgn2k darkdrgn2k closed this Dec 26, 2022
@darkdrgn2k darkdrgn2k deleted the nodejs-12 branch December 26, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants