Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make lodash a devDependency #930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jrop
Copy link

@jrop jrop commented Oct 30, 2018

I attempted to run tests on my Mac, but was unable, so I am starting this PR in hopes of starting the discussion of removing lodash as a hard dependency from this library. lodash has been left as a devDependency, however.

Please let me know what you guys think!

#813
#924

@joshuapaling
Copy link

Nice! I'll be using this fork, thanks for that.

@JustFly1984
Copy link

@joshuapaling
The repo of this project is unmaintained more than a year, and we had build new version https://www.npmjs.com/package/@react-google-maps/api

We had rewrite it to TypeScript, and updating it frequently: https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api
You can enjoy autocomplete.

You can see our docs: https://react-google-maps-api-docs.netlify.com/

Also a lot of examples: https://react-google-maps-api-gatsby-demo.netlify.com/ https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api-gatsby-example/src/examples

The bundle size is much smaller: https://bundlephobia.com/result?p=@react-google-maps/[email protected]

Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants