feat: move sarif builder outside of for-loop + linting

tomcarman · May 7, 2024 · 9ed8e23 · 9ed8e23
1 parent 9163b7f
commit 9ed8e23
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/commands/metalint/run.ts b/src/commands/metalint/run.ts
@@ -56,9 +56,9 @@ export default class MetalintRun extends SfCommand<MetalintRunResult> {
     });
     sarifRunBuilder.addRule(sarifRuleBuilder);
 
-    for (const field of fieldsWithoutDescriptions) {
-      const sarifResultBuilder = new SarifResultBuilder();
+    const sarifResultBuilder = new SarifResultBuilder();
 
+    for (const field of fieldsWithoutDescriptions) {
       // let path = process.env.SARIF_URI_ABSOLUTE ? pathToFileURL(field) : path.relative(process.cwd(), field).replace(/\\/g, '/') as const
 
       const sarifResultInit = {
@@ -70,13 +70,13 @@ export default class MetalintRun extends SfCommand<MetalintRunResult> {
 
       sarifResultBuilder.initSimple(sarifResultInit);
       sarifRunBuilder.addResult(sarifResultBuilder);
-
-      sarifBuilder.addRun(sarifRunBuilder);
-      const sarifResults = sarifBuilder.buildSarifJsonString({ indent: false });
-      // eslint-disable-next-line no-console
-      console.log(sarifResults);
     }
 
+    sarifBuilder.addRun(sarifRunBuilder);
+    const sarifResults = sarifBuilder.buildSarifJsonString({ indent: false });
+    // eslint-disable-next-line no-console
+    console.log(sarifResults);
+
     return { outcome: 'Complete' };
   }
 }