Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecation with catalina #90

Merged
merged 1 commit into from
Oct 25, 2019
Merged

fix deprecation with catalina #90

merged 1 commit into from
Oct 25, 2019

Conversation

tattali
Copy link
Contributor

@tattali tattali commented Oct 21, 2019

No description provided.

@tattali
Copy link
Contributor Author

tattali commented Oct 21, 2019 •
edited
Loading

Working binary QLMarkdown.qlgenerator.zip

$ mv QLMarkdown.qlgenerator ~/Library/QuickLook/QLMarkdown.qlgenerator
$ qlmanage -r

@tattali
Copy link
Contributor Author

tattali commented Oct 21, 2019

#89

@toland toland merged commit 13de2b6 into toland:master Oct 25, 2019
@setanarut setanarut mentioned this pull request Oct 26, 2019
Open
@tattali
Copy link
Contributor Author

tattali commented Oct 27, 2019

@toland @tarwich can you create a new release to update the homebrew cask version?
Thanks

@tarwich
Copy link
Collaborator

tarwich commented Oct 27, 2019

@tattali I would, but I don't have my Mac handy. Sorry about that. @toland ?

@tarwich
Copy link
Collaborator

tarwich commented Oct 27, 2019

Wait. Do we have to build it, or just create a release on GitHub to bump the version number?

@tattali
Copy link
Contributor Author

tattali commented Oct 27, 2019

Just a release with this binary attached.
I can handle the update of the formula if you want

@tarwich
Copy link
Collaborator

tarwich commented Oct 27, 2019

Version 1.3.6 should be good to go, @tattali

@tattali
Copy link
Contributor Author

tattali commented Oct 27, 2019 •
edited
Loading

Very nice! Thanks @tarwich !
I opened Homebrew/homebrew-cask#71523 I think the bot will merge it in few hours

@jspiro
Copy link

jspiro commented Oct 29, 2019

Screenshot 2019-10-28 at 10 21 35 PM

@tattali
Copy link
Contributor Author

tattali commented Oct 29, 2019

Try with #91 I don’t know why this binary doesn’t work

@bnussbau
Copy link

bnussbau commented Oct 29, 2019 •
edited
Loading

@jspiro Also download with Safari browser. See #89 (comment)

@setanarut setanarut mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tattali @tarwich @jspiro @bnussbau @toland