Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#76 Allow theme switch #77

Closed
wants to merge 1 commit into from
Closed

#76 Allow theme switch #77

wants to merge 1 commit into from

Conversation

tattali
Copy link
Contributor

@tattali tattali commented Apr 3, 2017

like in #76 commit that allow theme switch

# NAME_OF_THEME = default|github
$ defaults write com.fiatdev.QLMarkdown theme NAME_OF_THEME

@toland
Copy link
Owner

toland commented Apr 10, 2017

LGTM. @tarwich any thoughts?

@tarwich
Copy link
Collaborator

tarwich commented Apr 10, 2017

LGTM. But I haven't tested it. Have you had a chance to do so, @toland ?

PS: I was shocked at how fast this change came through. It's exactly what we were talking about.

@toland
Copy link
Owner

toland commented Apr 10, 2017

I haven't tested it. Have you had a chance to do so, @toland ?

Nope.

I was shocked at how fast this change came through. It's exactly what we were talking about.

Indeed.

@tattali
Copy link
Contributor Author

tattali commented Apr 10, 2017

Hi,
I have not found any bugs, but re-check it is more careful. Help with defaults in osx

Just be careful to clone : https://github.com/tattali/qlmarkdown.git
and not toland one (I did it once).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants