ci: test AArch64 Linux and run tests instead of build in cross job #763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, "cross" job in our CI is build-only and doesn't run tests:
bytes/.github/workflows/ci.yml
Lines 121 to 129 in 3ab876f
And AArch64 Linux which is tier1 in rustc is not tested.
bytes/.github/workflows/ci.yml
Lines 106 to 113 in 3ab876f
Solution
This PR adds
aarc64-unknown-linux-gnu
(ubuntu-22.04-arm) to matrix of tests on stable ("stable" job), and update "cross" job to run tests by using setup-cross-toolchain-action which is used in tokio. (see also tokio-rs/tokio#7123 for AArch64/Armv7hf)As for WASM testing, use
wasm32-wasip1
instead ofwasm32-unknown-unknown
becausewasm32-wasip1
can test withcargo test
command. (Testingwasm32-unknown-unknown
usually needswasm-pack
or other commands.)