Fix the startTransaction init error for development env #3040
Conversation
* [WIP] webpack config setup for fast refresh + websocket server * add prod/dev hmr webpack config option * render immediately and handle AsyncMessage in startup app hook * forward ui AsyncMessages to browser via WebSockets * null check sentry transaction to fix browser error * refactor AsyncMessageChannel code for browser implementation * webpack use swc-loader for browser version + speed/bundle size plugin options * prettify browser dev preview UI * enable loading screen if startup params missing (for web serve + disconnected browser dev preview) * attempt to fix webpack build for tests * add SpeedMeasurePlugin package * create AsyncMessageChannel dev docs * replace web-preview.md ASCII data flow diagram with mermaid * use radii/spacing tokens instead of px for web preview.tsx styles Co-authored-by: Jan Six <[email protected]> * remove commented out startup handler (handled in startup.tsx useEffect now) Co-authored-by: Jan Six <[email protected]> * remove commented out code Co-authored-by: Jan Six <[email protected]> * replace px values with tokens Co-authored-by: Jan Six <[email protected]> * conditional export for AsyncMessageChannel preview env * add browser preview WEBSOCKETS_PORT env * fix typescript issue with PreviewAsyncMessageChannel.isWsConnected * add test coverage for AsyncMessageChannelPreview * Browser preview debug UI (#2803) * fix AsyncMessageChannelPreview undefined error + export WS URI * browser preview CSS file for UI fixes * create previewUtils for browser color scheme + setFigmaBrowserTheme * browser preview URL params + fullscreen/theme/action modes * two bug fixes for browser/plugin websocket preview bridge * add preview dist folder for web preview builds * [WIP] browser preview dev knowledge docs * feat(dev): request startup on browser preview page open * refactor(dev): use env vars for browser preview ws src * fix(debug): remove console.log from asyncmessagechannelpreview * fix(css): figmaloading full height css for browser preview * refactor(dev): use enums for websockets src in browser preview tsx * fix(dev): remove comments * refactor: reuse htmlClassList variable * remove unused package --------- Co-authored-by: macintoshhelper <[email protected]> --------- Co-authored-by: macintoshhelper <[email protected]> Co-authored-by: Jan Six <[email protected]>
|
|
|
|
Commit SHA:b9c231cc5ffbd26c3c28a6e5375b025397f35ff7 Test coverage results 🧪
|
|
Commit SHA:b9c231cc5ffbd26c3c28a6e5375b025397f35ff7 |
| @@ -30,6 +30,7 @@ export const initializeSentry = () => { | |||
| switch (process.env.ENVIRONMENT) { | |||
| case 'alpha': | |||
| case 'beta': | |||
| case 'development': | |||
There was a problem hiding this comment.
Doesnt this mean we are also tracking errors in development ? Do we want that? Wouldnt Sentry get overloaded with errors that we dont care about because theyre not in prod or any beta version?
There was a problem hiding this comment.
Got it, I will disable error log collection for dev environment
akshay-gupta7
force-pushed
the
fix-console-errors
branch
from
52a7934
to
5523bd8
Compare
| break; | ||
| case 'development': | ||
| Sentry.init({ | ||
| dsn: '', | ||
| release: `figma-tokens@${pjs.version}`, | ||
| environment: process.env.ENVIRONMENT, | ||
| tracesSampleRate: 0, | ||
| profilesSampleRate: 0, | ||
| replaysSessionSampleRate: 0, | ||
| replaysOnErrorSampleRate: 0, | ||
| integrations: [], | ||
| }); |
There was a problem hiding this comment.
does this make sense @six7
fixes the following error on console: