fix(portal-contract): wrong 'from' when depositing from the contract through Portal.onApprove function #275
+6
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved: External Issue #39
I added a new test for these changes but removed because it only worked with
forge test --match-contract OptimismPortal2_Test
.With the contract
DeploymentSummaryFaultProofs_TestOptimismPortal
that is usingKontrol
,vm.startPrank
didn't work withl2NativeToken.mint(value)
orl2NativeToken.approveAndCall
: issueSo we can add the test later. My test