Draft: Prevent locking funds when using sendMessage with the target is an EOA and value > 0 #266
+56
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an EOA and value > 0
0x6e616d
requested review from
nguyenzung and
rlgns98kr
and removed request for
nguyenzung
rlgns98kr
reviewed
Sep 11, 2024
These changes are from the internal audit. Related to this problem we discussed before |
0x6e616d
changed the title
|
I changed it to the Draft PR. We will decide when the external audit report is finished. |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L1XDMcontract, we prevent sendingETHto this contract when usingsendMessagefunctionL2XDMcontract, we prevent sending the native token and the _target is an EOA when usingsendMessagefunction, because in therelayMessage, the _target must transfer the native token when that is called.