Or 1843 merge internal audit to main #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlgns98kr
reviewed
Sep 10, 2024
| @@ -28,6 +28,14 @@ var ( | |||
| _ = event.NewSubscription | |||
| ) | |||
|
|
|||
| // TypesOutputRootProof is an auto generated low-level Go binding around an user-defined struct. | |||
There was a problem hiding this comment.
We have to delete it manually!
rlgns98kr
reviewed
Sep 10, 2024
| @@ -23,5 +23,5 @@ func init() { | |||
|
|
|||
| layouts["UniswapV3Factory"] = UniswapV3FactoryStorageLayout | |||
| deployedBytecodes["UniswapV3Factory"] = UniswapV3FactoryDeployedBin | |||
| immutableReferences["UniswapV3Factory"] = false | |||
| immutableReferences["UniswapV3Factory"] = true | |||
There was a problem hiding this comment.
We have to revert this manually!
…ternal-audit feat: update sdk by internal audit
…rting-of-the-Native-token-feature-for-OptimismPortal2.sol apply L2 native token for OptimismPortal2
Or 1849 resolve e2e and sdk
nguyenzung
force-pushed
the
OR-1843-merge-internal-audit-to-main
branch
from
570dc41
to
b842e66
Compare
…contracts-test Or 1852 thanos resolve contracts test
nguyenzung
requested review from
ohbyeongmin,
AaronLee22,
xxeonge,
a team and
rlgns98kr
…d-comments Or 1851 update readme and comments
theo-learner
approved these changes
Sep 12, 2024
rlgns98kr
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For comparison, I will close. Please ignore