Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OR-1797): update Thanos SDK by new specs #209

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

0x6e616d
Copy link
Member

No description provided.

@0x6e616d 0x6e616d requested a review from a team August 16, 2024 01:19
@0x6e616d 0x6e616d self-assigned this Aug 16, 2024
@0x6e616d 0x6e616d changed the base branch from main to codeReview August 16, 2024 01:19
@theo-learner
Copy link
Collaborator

theo-learner commented Aug 16, 2024

Thank you! Could you fix the lint of packages/tokamak/sdk/tasks/deposit-withdraw-erc20.ts?

  • hint: pnpm lint:fix in sdk

@0x6e616d
Copy link
Member Author

Thank you! Could you fix the lint of packages/tokamak/sdk/tasks/deposit-withdraw-erc20.ts?

  • hint: pnpm lint:fix in sdk

Thank you, I am done

@theo-learner
Copy link
Collaborator

@0x6e616d Could you check the task deposit-eth? If I set the amount is 0 or more than 1, It seems the result does not make sense.

  • amount is 0: deposit is successful.
  • amount is more than 1: got error "insufficient funds for gas * price + value: address 0x0000000000000000000000000000000000000000 have 1 want 2"

@0x6e616d
Copy link
Member Author

0x6e616d commented Aug 16, 2024

@0x6e616d Could you check the task deposit-eth? If I set the amount is 0 or more than 1, It seems the result does not make sense.

  • amount is 0: deposit is successful.
  • amount is more than 1: got error "insufficient funds for gas * price + value: address 0x0000000000000000000000000000000000000000 have 1 want 2"

I missed the "from" when estimating the deposit ETH transaction, so when depositing, the code used the default address(0x...). By default, this address has 1 ETH, so when we estimate the amount is larger than 1, the estimated code is not functioning properly.

@0x6e616d 0x6e616d merged commit 5ad9baa into codeReview Aug 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants