Or 1555 titan cannon check and update some withdrawal native token cases based on feedback from audit #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenzung
requested review from
theo-learner,
ohbyeongmin,
rlgns98kr,
AaronLee22,
xxeonge and
0x6e616d
nguyenzung
force-pushed
the
OR-1555-titan-cannon-check-and-update-some-withdrawal-native-token-cases-based-on-feedback-from-audit
branch
from
35b4cff
to
5a7a6fe
Compare
nguyenzung
force-pushed
the
OR-1796-Native-token-update-Native-token-based-on-the-new-spec
branch
from
8cfbfe9
to
f0759df
Compare
nguyenzung
force-pushed
the
OR-1555-titan-cannon-check-and-update-some-withdrawal-native-token-cases-based-on-feedback-from-audit
branch
from
288d841
to
c86bfd6
Compare
nguyenzung
force-pushed
the
OR-1555-titan-cannon-check-and-update-some-withdrawal-native-token-cases-based-on-feedback-from-audit
branch
from
f1ce702
to
c7ea5d6
Compare
rlgns98kr
approved these changes
Aug 13, 2024
nguyenzung
merged commit 221bfea
into
OR-1796-Native-token-update-Native-token-based-on-the-new-spec
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From audit team: does not allow msg.value when withdraw ETH or ERC20
I am updating the code on the branch OR-1796-Native-token-update-Native-token-based-on-the-new-spec.
When everything is okay, I will make a PR to merge OR-1796-Native-token-update-Native-token-based-on-the-new-spec to the branch code_review for internal audit by FBI.
Thank you!