Fix running on Python 3.12 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.12 deprecated the distutils module, which we use to check the version of matplotlib and error out if it's too old. Arguably, this is a bit overkill anyway, so replace it with a simple check of the major version by splitting the version string on periods. While we're at it, also reject matplotlib version 2.*, since we already removed that from CI testing. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Update the test matrix to include the latest versions of Python and Matplotlib. Also update the excluded combinations to exclude old matplotlib versions with Python 3.11 and 3.12, and to exclude Python 3.8 for matplotlib 3.8. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Starting with Python 3.12, setuptools is no longer installed by default. Install it explicitly with pip as part of the selftest setup. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Some tests are flaky because of subprocess exit handling. Add more complete handling of the possible return values from os.waitpid() to be able to debug the cause of this flakiness. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
The dash-separated test-suite config key is deprecated in favour of test_suite. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Some of the test matrix combinations causes segfaults in the forking test runner when using PySide2. Exclude these tests from the test matrix for now; they can be reinstated if the segfault is fixed. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
tohojo
force-pushed
the
python-312-fix
branch
from
ab915be
to
34a977d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distutils module was deprecated in Python 3.12, so let's stop using it.
Fixes #296.