Fixed log-scale matplotlib compatibility for v3.3 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohojo
requested changes
Aug 9, 2023
freysteinn
changed the title
|
I've updated the pull request to check for Matplotlib version 3.3 instead of the incorrect version 3.2. I also tested the commit using Python 8 and Matplotlib 3.2.2. |
tohojo
reviewed
Apr 9, 2024
The matplotlib package removed all axis directions from the base parameters for logarithmic scaling functions in v3.3.0 and up. This commit supports both the original "basex" and "basey" parameters for older versions of matplotlib and the new "base" parameter for more recent versions of matplotlib. Signed-off-by: Frey Alfredsson <[email protected]>
tohojo
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matplotlib package removed all axis directions from the base parameters for logarithmic scaling functions in v3.3.0 and up.
This commit supports both the original "basex" and "basey" parameters for older versions of matplotlib and the new "base" parameter for more recent versions of matplotlib.