Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build platforms and outdated checkout action #438

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

inkarkat
Copy link
Member

And allow for manual workflow triggering as well as using Dependabot to automatically offer GitHub actions updates.

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Lint your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

@inkarkat inkarkat force-pushed the bump/workflow branch 2 times, most recently from 4815442 to 1c932eb Compare September 21, 2024 10:36
MacOS 11 is unsupported and the builds are just hanging due to the missing image.
To silence this warning:
> The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2
… GitHub actions

This will automatically scan our workflow once a week and open PR(s) with updates to GitHub actions.
…ar^^} (after ca444e4)

This went undetected because the CI/CD pipeline was broken again due to an outdated MacOS image.
Continue to use tr for uppercasing. Enable pipefail so that grep (which needs to happen before the uppercasing) result is still considered.

(This corrects commit ca444e4)
Copy link
Member

@karbassi karbassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@inkarkat inkarkat merged commit a916aa9 into todotxt:master Sep 26, 2024
2 checks passed
@inkarkat inkarkat deleted the bump/workflow branch September 26, 2024 12:51
@inkarkat
Copy link
Member Author

@karbassi Thanks for accepting this; I think it's finally time for a new release. 🎉 That attention might prompt other contributors to update their PRs; there are still a few that could be merged.

I would be nice if you document what's required to do a release, and give other maintainers (@hyperupcall is still waiting to be added; cp. todotxt/todo.txt#80; I myself would also rather have the means to make a release that rather than see the project languish for so long) the rights to do so as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants