Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #5

Merged
merged 5 commits into from
May 7, 2020
+26 −12
Merged

Improve CI #5

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98b73fe
Update nodejs.yml
May 7, 2020
f9f1d02
Update .github/workflows/nodejs.yml
May 7, 2020
9f0f479
Update nodejs.yml
May 7, 2020
fc3f8de
fix typo
May 7, 2020
d4dc6e0
Update .github/workflows/nodejs.yml
May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,40 @@
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Node.js CI
name: Node CI

on:
push:
branches: [ master ]
pull_request:
branches: [ master ]
on: [push]

jobs:
build:
toddocon marked this conversation as resolved.
Show resolved Hide resolved

runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit this suggestion directly.

Suggested change
runs-on: ubuntu-latest
needs: build


steps:
- uses: actions/checkout@v1
- name: npm install and build webpack
run: |
npm install
npm run build

test:

runs-on: ubuntu-latest

strategy:
matrix:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit this suggestion directly.

Suggested change
matrix:
- uses: actions/download-artifact@master
with:
name: webpack artifacts
path: public
- name: npm install, and test

node-version: [10.x, 12.x]
os: [ubuntu-lastest, windows-2016]
node-version: [8.x, 10.x]
toddocon marked this conversation as resolved.
Show resolved Hide resolved

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm run build --if-present
- run: npm test
- name: npm install, and test
run: |
npm install
npm test
env:
CI: true