Implement debug command #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tockloader/openocd.py
Outdated
| return ocd_p | ||
|
|
||
| def _run_gdb_client(self, binary): | ||
| gdb_command = f'arm-none-eabi-gdb --exec {binary} --symbols {binary} -eval-command="target remote localhost:3333"' |
There was a problem hiding this comment.
would gdb-multiarch work just as well here? Otherwise this command only works on arm boards
There was a problem hiding this comment.
You're right.
I think gdb-multiarch is not present on a lot of system. People tends to use gdb or arm-none-eabi-gdb.
So, to use the correct gdb, I suggest this:
- Check for "gdb-multiarch" in PATH
- If not in PATH, use gdb or arm-none-eabi-gdb depending on self.arch variable.
Would it be better ?
Thanks
There was a problem hiding this comment.
Choosing based on the board arch is fine. Maybe that won't work in all cases, but that is OK for now.
bradjc
reviewed
Nov 22, 2022
tockloader/openocd.py
Outdated
| return ocd_p | ||
|
|
||
| def _run_gdb_client(self, binary): | ||
| gdb_command = f'arm-none-eabi-gdb --exec {binary} --symbols {binary} -eval-command="target remote localhost:3333"' |
There was a problem hiding this comment.
Choosing based on the board arch is fine. Maybe that won't work in all cases, but that is OK for now.
|
Can you include example usage in the readme? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This a command to support the "debug-binary" command in tockloader. This command allows to debug a binary on the board. It does not flash the binary on the board, only runs gdb and load a symbol file.
Since "--debug" would conflict with "debug", it is called "debug-binary". If it's a problem, we could rename "--debug" with "--verbose" to fix this issue.