Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move lora examples to wip directory #401

Merged
merged 2 commits into from
Apr 17, 2024
Merged

move lora examples to wip directory #401

merged 2 commits into from
Apr 17, 2024

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Apr 12, 2024

The main change here is moving the lora examples to a folder where they are not on the critical path for building and passing CI. For #370 we are updating libtock, but these apps use code that references libtock in a different library. To make progress on #370 this makes them not have to build.

The folder doesn't have to be called "legacy", that is just the first idea I had.

Removes them from the critical path of building.
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving seems pragmatic.

Re name: I think this is still somewhat fresh and recent work from Alistair, so legacy perhaps misleading.

Maybe something more explicit like a "wip" folder, with readme explaining stuff in that folder isn't tested by CI or vetted as heavily, and a short explanation in the Lora example readme of why it's wip?

@alistair23
Copy link
Contributor

I'm not sure I follow. Why remove this from the CI?

The LoRa stuff works really well. It's probably the most reliable wireless support Tock has. It's also not WIP, the actual LoRa code is very robust. I have a PR open to transmit GNSS data as well

@bradjc
Copy link
Contributor Author

bradjc commented Apr 15, 2024

Why remove this from the CI?

We need it to support RISC-V, and we need to be able to update libtock function names without patching a different library.

@bradjc bradjc changed the title move lora examples to legacy directory move lora examples to wip directory Apr 15, 2024
@alistair23
Copy link
Contributor

Do you have a RISC-V board with LoRa? There isn't any reason it won't support RISC-V

Are we really changing the libtock-c APIs so often that we can't call them from external libraries? That makes using libtock-c for anything besides test examples really hard

@bradjc
Copy link
Contributor Author

bradjc commented Apr 16, 2024

Are we really changing the libtock-c APIs so often that we can't call them from external libraries?

Yes and no. We are changing them (they really need to be updated). But an external library can pin to a version. The issue is the circle in the lora examples.

Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so long as we want a policy of "risc-v builds are on by default", then an example app that doesn't work on risc-v would necessarily qualify as wip [i.e., until it works on "all officially supported archs"].

@ppannuto ppannuto added this pull request to the merge queue Apr 17, 2024
Merged via the queue into master with commit cd47e9d Apr 17, 2024
4 checks passed
@ppannuto ppannuto deleted the radiolib-legacy branch April 17, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants