Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add u8g2 library support #363

Merged
merged 15 commits into from
Mar 10, 2024
Merged

Add u8g2 library support #363

merged 15 commits into from
Mar 10, 2024

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jan 19, 2024

u8g2 is a C library for creating text and graphics on monochrome displays.

This uses the screen driver with the u8g2 library.

I also included a handful of demo apps.

@bradjc bradjc force-pushed the u8g2 branch 2 times, most recently from 10b34db to 63c9f79 Compare February 9, 2024 03:39
Copy link
Member

@alevy alevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is very little to approve here. The changes to libtock are minimal. The main body of code is in u8g2/u8g2-tock.c, which specializes the u8g2 library for Tock. Here, the main thing that is not straightforward is dynamically setting the screen info based on the what the driver responds in u8x8_d_ssd1306_tock.

The code here is not very self explanatory, and I needed to dig through the u8g2 library code to understand the flow of operations.

@brghena
Copy link
Contributor

brghena commented Mar 8, 2024

I haven't looked yet, but given that Amit approves and Tyler has tested this, I think we can safely last-call it.

@alevy alevy added this pull request to the merge queue Mar 10, 2024
Merged via the queue into master with commit 691045f Mar 10, 2024
4 checks passed
@alevy alevy deleted the u8g2 branch March 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants