Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test: delay before discover #340

Merged
merged 1 commit into from
Aug 29, 2023
Merged

unit test: delay before discover #340

merged 1 commit into from
Aug 29, 2023

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Aug 25, 2023

Ensure the service has time to register.

With KV testing I've had to manually add this delay to get the unit test framework to work.

Ensure the service has time to register.
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delay is a bit hack-y; in a real app probably should be some kind of retry loop, but for a unit test I think this is fine.

Maybe someday IPC should have an async / upcall / notify when service exists kind of thing, but the queue of IPC reform is long 😬

@ppannuto ppannuto added this pull request to the merge queue Aug 29, 2023
Merged via the queue into master with commit 9596abb Aug 29, 2023
2 checks passed
@ppannuto ppannuto deleted the unit-test-delay branch August 29, 2023 20:12
tyler-potyondy pushed a commit to tyler-potyondy/libtock-c that referenced this pull request Mar 13, 2024
unit test: delay before discover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants