Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell.nix: update to Tockloader v1.11.0pre-git #338

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

lschuermann
Copy link
Member

@lschuermann lschuermann commented Aug 20, 2023

Pull Request Overview

This pull request updates the Tockloader release pinned in shell.nix to a development revision towards v1.11.0. It switches to the Tockloader package definition now included in its repo.

Testing Strategy

This pull request was tested by evaluating the Nix expression.

TODO or Help Wanted

This change depends on tock/tockloader#104! It deliberately does not evaluate (sha256 = ""), to ensure that we update the rev to a revision with tock/tockloader#104 merged in.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@lschuermann lschuermann requested a review from alevy August 20, 2023 20:25
@alevy
Copy link
Member

alevy commented Aug 21, 2023

Seems good now that tock/tockloader#104 is merged

@bradjc
Copy link
Contributor

bradjc commented Sep 6, 2023

We can merge this now?

alevy
alevy previously approved these changes Sep 7, 2023
@alevy
Copy link
Member

alevy commented Sep 7, 2023

@lschuermann can you change this to a regular (non-draft) PR?

@lschuermann lschuermann changed the title shell.nix: update to Tockloader v1.10.0 shell.nix: update to Tockloader v1.11.0pre-git Sep 8, 2023
@lschuermann lschuermann marked this pull request as ready for review September 8, 2023 01:13
@lschuermann
Copy link
Member Author

Yikes, I had the changes necessary to make this work locally but didn't push... 😒

I changed this PR's title and description to be more accurate -- we are, in fact, pinning a specific development revision (somewhere in between v1.10.0 and v1.11.0), as that ships with the required default.nix file.

This should be good to go now.

@alevy alevy added this pull request to the merge queue Sep 8, 2023
Merged via the queue into tock:master with commit c7d8279 Sep 8, 2023
2 checks passed
tyler-potyondy pushed a commit to tyler-potyondy/libtock-c that referenced this pull request Mar 13, 2024
shell.nix: update to Tockloader v1.11.0pre-git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants