Double translation can lead to infinite stack (geonetwork#8209)

* removed double translation * additional fix for double translation
tobias-hotz · Jun 25, 2024 · aed2eb1 · aed2eb1
1 parent 4728e7d
commit aed2eb1
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/web-ui/src/main/resources/catalog/components/admin/harvester/partials/extras.html b/web-ui/src/main/resources/catalog/components/admin/harvester/partials/extras.html
@@ -8,17 +8,17 @@
                      || harvester['@type'] == 'filesystem'"
   >
     <label class="control-label">
-      <span data-translate="">{{"harvesterOverrideUUID" | translate}}</span>
+      <span>{{"harvesterOverrideUUID" | translate}}</span>
     </label>
     <select data-ng-model="harvester.options.overrideUuid" class="form-control">
       <option value="SKIP">
-        <span data-translate="">{{"harvesterOverrideUUID-skip" | translate}}</span>
+        <span>{{"harvesterOverrideUUID-skip" | translate}}</span>
       </option>
       <option value="OVERRIDE">
-        <span data-translate="">{{"harvesterOverrideUUID-overwrite" | translate}}</span>
+        <span>{{"harvesterOverrideUUID-overwrite" | translate}}</span>
       </option>
       <option value="RANDOM">
-        <span data-translate="">{{"harvesterOverrideUUID-random" | translate}}</span>
+        <span>{{"harvesterOverrideUUID-random" | translate}}</span>
       </option>
     </select>
     <span class="help-block ng-scope" data-translate="">harvesterOverrideUUIDHelp</span>

diff --git a/...n/resources/catalog/components/metadataactions/partials/associatedResourcesContainer.html b/...n/resources/catalog/components/metadataactions/partials/associatedResourcesContainer.html
@@ -14,7 +14,7 @@ <h2 class="onlinesrc-title gn-relation-type-{{config.type}}">
           data-ng-click="onlinesrcService.onOpenPopup(config.type, config.config)"
         >
           <i class="fa fa-fw fa-plus"></i>
-          <span data-translate="">{{ config.label | translate}}</span>
+          <span>{{ config.label | translate}}</span>
         </a>
       </h2>
       <div

diff --git a/...resources/catalog/components/metadataactions/partials/distributionResourcesContainer.html b/...resources/catalog/components/metadataactions/partials/distributionResourcesContainer.html
@@ -21,7 +21,7 @@ <h2 data-ng-if="config.title.indexOf('<') === -1">
           data-ng-click="onlinesrcService.onOpenPopup('onlinesrc', action)"
         >
           <i class="fa fa-fw fa-plus"></i>
-          <span data-translate="">{{ action | translate}}</span>
+          <span>{{ action | translate}}</span>
         </a>
       </div>
     </div>

diff --git a/web-ui/src/main/resources/catalog/views/default/directives/partials/mdactionmenu.html b/web-ui/src/main/resources/catalog/views/default/directives/partials/mdactionmenu.html
@@ -229,14 +229,14 @@
           target="_blank"
         >
           <span class="fa fa-fw {{f.class}}"></span>&nbsp;
-          <span data-translate="">{{f.label | translate}}</span>
+          <span>{{f.label | translate}}</span>
         </a>
         <a
           data-ng-if="!!f.url === false && f.label.indexOf('PDF') !== -1"
           href="javascript:print();"
         >
           <span class="fa fa-fw {{f.class}}"></span>&nbsp;
-          <span data-translate="">{{f.label | translate}}</span>
+          <span>{{f.label | translate}}</span>
         </a>
       </li>
     </ul>

diff --git a/web-ui/src/main/resources/catalog/views/default/templates/recordView/technical.html b/web-ui/src/main/resources/catalog/views/default/templates/recordView/technical.html
@@ -15,7 +15,7 @@
           ></i>
         </div>
         <span>
-          <h3 data-translate>{{date.type | translate}}</h3>
+          <h3>{{date.type | translate}}</h3>
           <span data-gn-humanize-time="{{date.date}}"></span>
         </span>
       </li>
@@ -79,9 +79,7 @@ <h3 data-translate="">updateFrequency</h3>
       <i class="fa fa-fw fa-tags"></i>
     </span>
     <div>
-      <h3 data-translate="">
-        {{(t.multilingualTitle.default || t.title || key) | translate}}
-      </h3>
+      <h3>{{(t.multilingualTitle.default || t.title || key) | translate}}</h3>
 
       <div data-gn-keyword-badges="mdView.current.record" data-thesaurus="key"></div>
     </div>