feat: Activities with evidences as attachment #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to EvidenceController
…part max-file-size to 100MModify /activity/{activityId}/evidence Controller to return Multipart.
…Id to getActivityEvidence
…ase and evidence not found exception
…ase to return DTO Object
… retrieve in the repository
ssubijana
reviewed
Sep 7, 2023
| @@ -25,7 +25,6 @@ class ActivitiesResponseConverter( | |||
| project = activity.projectRole.project, | |||
| projectRole = activity.projectRole, | |||
| duration = activity.duration, | |||
| hasImage = activity.hasEvidences | |||
There was a problem hiding this comment.
Mejor poner el valor a false. Este conversor se usa para la API del hook. Si nos cargamos este campo rompemos la integración actual
| @@ -15,5 +15,4 @@ data class ActivitiesResponse( | |||
| val billable: Boolean, | |||
| val organization: Organization, | |||
| val project: Project, | |||
| val hasImage: Boolean? | |||
There was a problem hiding this comment.
Lo mismo aquí: no quitar el campo hasImage, rompemos el contrato con el hook!!
| @@ -13,7 +13,5 @@ data class ActivityRequestBodyHookDTO( | |||
| val description: String, | |||
| val billable: Boolean, | |||
| val projectRoleId: Long, | |||
| val hasImage: Boolean, | |||
There was a problem hiding this comment.
No podemos romper la API del Hook!!!!
...ncept-binnacle/src/main/kotlin/com/autentia/tnt/binnacle/usecases/ActivityDeletionUseCase.kt
Outdated
Show resolved
Hide resolved
tntconcept-binnacle/src/main/kotlin/com/autentia/tnt/binnacle/usecases/ActivityUpdateUseCase.kt
Outdated
Show resolved
Hide resolved
tntconcept-ddbb/src/main/resources/db/migration/V016__activity_attachments.sql
Outdated
Show resolved
Hide resolved
…o feat/activity_evidence
…o feat/activity_evidence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Change the API so in the request there is no evidences as base64 string but an array with all the attachment identifiers that represents an evidence. Also, the flag hasEvidence has been redesigned.
There is a new intermediate table ActivityEvidence that associates the activities with the attachment table
Create/Update/Delete use cases had been modified to use the new attachments and stop using the old ones
Review / Tests
isTemporaryflag must befalsefrom the initialtrueisTemporaryflag must betrueand the new attachmentfalse