Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add special char to token pattern to allow tokens with that #30

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix: add special char to token pattern to allow tokens with that #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TNTGitHook/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def first(function: Callable[[T], bool], iterable: Iterable[T]) -> T:
def formatRemoteURL(remoteURL) -> str:

userPattern = "\/+\w.*\:"
tokenPattern = "\:+([\w\d]*)@"
tokenPattern = "\:+([\w\d-]*)@"

if(remoteURL is None):
return remoteURL
Expand Down
2 changes: 1 addition & 1 deletion utils_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def test_parse_full_activities_data(self):
self.assertIsNotNone(activity.projectRole)

def test_replace_user_and_token_when_remote_url_contains_them(self):
remoteURL = "https://nassr.mousati:[email protected]/user/dummy.git"
remoteURL = "https://nassr.mousati:ghp_LuToBb2F-@github.com/user/dummy.git"
expectedRemoteURL = "https://****:****@github.com/user/dummy.git"
formatedRemoteURL = formatRemoteURL(remoteURL)
self.assertEqual(formatedRemoteURL, expectedRemoteURL)
Expand Down
Loading