Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: [Patch] Reduce CTE repetition #41

Conversation

cpita-felix
Copy link

Refactoring macros/dataset.sql to reduce the number of references to the original activity stream CTE/ref passed into it. Should therefore reduce average runtime of the macro as CTE logic/disk reads are performed less frequently.

@cpita-felix
Copy link
Author

going to close this PR. My intention was to rewrite dataset.sql as a series of direct left joins between activities, but I realized that that join could explode and generate spurious tuples, which would make it much slower to execute, and would require significant special case handling for the aggregate style relationships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant