Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Errors #59

Merged
merged 10 commits into from
Jul 25, 2023
Merged

Better Errors #59

merged 10 commits into from
Jul 25, 2023

Conversation

ingalls
Copy link
Contributor

@ingalls ingalls commented Jun 12, 2023 •
edited
Loading

Context

  • Include the ByteSize of the image in the CreateImage request to allow the API to throw an error if the image size exceeds the current (4mb) limit of the serverless infra
  • Standardize API calls via the fetcher function to keep the code a little simpler
  • Conditionally attach unhandled errors to the created Image object (if it was created)

Sibling PR: tnc-ca-geo/animl-api#102

@ingalls ingalls mentioned this pull request Jun 12, 2023
Merged
@ingalls ingalls self-assigned this Jul 21, 2023
@nathanielrindlaub nathanielrindlaub merged commit 94582e4 into master Jul 25, 2023
3 checks passed
@ingalls ingalls deleted the better-error branch July 25, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielrindlaub nathanielrindlaub nathanielrindlaub approved these changes

Assignees

@ingalls ingalls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingalls @nathanielrindlaub