Improve JSON parsing using annotated model-classes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmyroadctfig
requested changes
Aug 8, 2017
build.gradle
Outdated
| } | ||
| } | ||
| } | ||
| } |
| /** | ||
| * Access to the iCloud Drive service. | ||
| * | ||
| * @author Luke Quinanne | ||
| */ | ||
| public class DriveService | ||
| { | ||
| public class DriveService { |
There was a problem hiding this comment.
Braces are on the next line for this project.
| @@ -53,8 +53,9 @@ | |||
| * @param response the HTTP response. | |||
| * @param errorMap the map of error values returned by iCloud. | |||
| */ | |||
| public ICloudException(HttpResponse response, Map<String, Object> errorMap) | |||
| public ICloudException(HttpResponse response, Map<String, Object> errorMap, Throwable cause) | |||
| import com.google.gson.annotations.Expose; | ||
| import com.google.gson.annotations.SerializedName; | ||
|
|
||
| public class AppleDevice { |
| import com.google.gson.annotations.Expose; | ||
| import com.google.gson.annotations.SerializedName; | ||
|
|
||
| public class Features { |
|
Hello @tmyroadctfig , Some more javadocs and other enhancements will follow soon. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using annotated model-classes to parse JSON objects.
reworked package structure of the project a bit.