Skip to content

Commit

Permalink
test(test_capture_pane): Remove bashisms (#455)
Browse files Browse the repository at this point in the history
In an effort to reduce reliance on specific shells so tests
and development works across as many machines as possible,
avoid explicitly mentioning shells. re: #454

There's an issue: What about fish? It departs greatly from
other shells.  Is there a way we can have tests and a capture_pane
that works everywhere? #456
  • Loading branch information
tony authored Nov 5, 2022
2 parents 5869e01 + bdd7122 commit 74d600b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@ $ pip install --user --upgrade --pre libtmux

### Tests

_There will be more tests over the coming weeks and months to shore up
flakiness across shells and environments._

- Compatibility improvement for `test_capture_pane` and `env` (#452), credit:
@zappolowski!
- Remove more BASHisms from tests (#455)

## libtmux 0.15.9 (2022-10-30)

Expand Down
2 changes: 1 addition & 1 deletion src/libtmux/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class tmux_cmd:
Equivalent to:
.. code-block:: bash
.. code-block:: console
$ tmux new-session -s my session
Expand Down
2 changes: 1 addition & 1 deletion tests/test_pane.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def test_capture_pane(session: Session) -> None:
session.new_window(
attach=True,
window_name="capture_pane",
window_shell=f"{env} PS1='$ ' bash --norc --noprofile",
window_shell=f"{env} PS1='$ ' sh",
)
pane = session.attached_window.attached_pane
assert pane is not None
Expand Down

0 comments on commit 74d600b

Please sign in to comment.