fix(cli,install): authenticity of host 'github.com' can't be established #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurs because the URL used to connect to GitHub is for SSH. This is not necessary. HTTPS is enough. This causes the `install_plugins` command to hang when used noninteractively on automation platforms such as GitHub Actions or Ansible. Resolves tmux-plugins#219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
install_pluginscommand noninteractively on automation platforms such as GitHub Actions or Ansible, it can sometimes hang and never complete. When I ran the command interactively, it prompted me to either accept or reject to the host key of an unknown host.I found out the cause was the plugin https://github.com/alexwforsythe/tmux-which-key having a git submodule with an SSH URL: https://github.com/alexwforsythe/tmux-which-key/blob/main/.gitmodules . For open source projects, this is an error.
This pull request proposes to exit the
install_pluginscommand immediately if the host is unknown.Resolves #219