Fix jazz logs unit test #830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2019 15:45
pspani
suggested changes
Feb 20, 2019
| @@ -6,6 +6,7 @@ const awsContext = require('aws-lambda-mock-context'); | |||
| const sinon = require('sinon'); | |||
| const logger = require("../components/logger.js"); | |||
| const request = require('request'); | |||
| const _ = require('lodash'); | |||
There was a problem hiding this comment.
We are reducing our dependence on third-party libraries. One of them is lodash. We are replacing all lodash usages in the code with js native functions. Please remove lodash and use native functions
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
npm testincore/jazz_logsDescription of the Change
I fixed the four broken unit tests in this branch as well as upgraded sinon to the latest version. I changed the request() call to request.post() so that I could stub this request in the unit test. request() apparently is impossible to stub which you can read about here: https://stackoverflow.com/questions/20050507/creating-request-stub-with-sinon-in-mocha
I replaced sinon.stub(object, "method", func) with sinon.stub(object, "method").callsFake(func) as the first method is deprecated.
I added LOG_LEVELS to the test config JSON file. This is required, otherwise map() blows up and makes the tests fail.
Benefits
The unit tests pass
Possible Drawbacks
I'm not sure if there's any potential issues by using request.post() instead of request(), but there shouldn't be.
Applicable Issues
#625