Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for calendar years, calendar months and more #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature: Add support for calendar years, calendar months and more #43

wants to merge 5 commits into from

Conversation

jufemaiz
Copy link

@jufemaiz jufemaiz commented May 14, 2018

  • Supports inclusive vs exclusive date ranges
  • Respects timezones
  • Correctly calculates differences over leap years (does not assume 365.25 days
    in a year or 30.42 days in a month)
  • Correctly corrects for daylight savings
  • Support for in_calendar_years and in_calendar_months for monthly and yearly
    billing cycle calculation support
  • Use of rounding as an option rather than hardcoded 2 (set as default option to prevent breakage)

@jufemaiz
Copy link
Author

Ref:

@jufemaiz
Copy link
Author

bump

@bmoelk
Copy link

bmoelk commented Apr 2, 2019

 > TimeDifference.between('Oct 21, 2017'.to_time, Time.now).in_years
 => 1.45 

IMO: Please rename your fork (https://github.com/IQTHINK/time_difference) and become the maintainer. This gem appears to be abandoned. 9 open PR's 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants