Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an in_calendar_months feature #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pedantic-git
Copy link

This adds a method that does a more "human" calculation of months, taking into account calendar time in the current timezone (so you always get an integer number of months and the 4th of the month to the 4th of the month is always 1 month).

It doesn't touch in_components or in_general and it could probably be refactored slightly to be a shorter method, but it does the job I need!

Let me know what you think or if you'd like me to change anything.

@AlexWayfer
Copy link

I'm also interested in methods like in_calendar_years. Maybe, this can be an option, like in_years(calendar: true), in_months(calendar: true) and even in_general(calendar: true).

@AlexWayfer
Copy link

For note: there is the fork with such methods: https://github.com/IQTHINK/time_difference

@joecabezas
Copy link

no updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants